Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/refactor/eg: test case claims it should be failing, but it isn't. #40497

Open
seebs opened this issue Jul 30, 2020 · 1 comment
Open

x/tools/refactor/eg: test case claims it should be failing, but it isn't. #40497

seebs opened this issue Jul 30, 2020 · 1 comment

Comments

@seebs
Copy link
Contributor

@seebs seebs commented Jul 30, 2020

What version of Go are you using (go version)?

1.14

Does this issue reproduce with the latest release?

Sure.

What did you do?

go test

What did you expect to see?

A test failure.

What did you see instead?

The test passed.

This might seem like it's not surprising, but:

	// Should be no match however currently matches due to:
	// https://golang.org/issue/8584
	// Will start failing when this is fixed then just change golden to
	// No match pointer indirect
	// a.Lock()
	a.Lock()

That issue has been fixed for a long time, but apparently it's still matching. I don't yet understand the code's design intent well enough to know whether this comment is wrong, or there's a new/different bug, or ???

@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Aug 3, 2020

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants