x/tools/refactor/eg: test case claims it should be failing, but it isn't. #40497
Description
What version of Go are you using (go version)?
1.14
Does this issue reproduce with the latest release?
Sure.
What did you do?
go test
What did you expect to see?
A test failure.
What did you see instead?
The test passed.
This might seem like it's not surprising, but:
// Should be no match however currently matches due to:
// https://golang.org/issue/8584
// Will start failing when this is fixed then just change golden to
// No match pointer indirect
// a.Lock()
a.Lock()
That issue has been fixed for a long time, but apparently it's still matching. I don't yet understand the code's design intent well enough to know whether this comment is wrong, or there's a new/different bug, or ???