Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/compile: for range loop reading past slice end [1.13 backport] #40500
@BLasan Sorry, there's nothing left to do on this particular issue. All that needs to happen is to merge CL 245957 into the release branch. Whoever packages up the next 1.13 point release will do that.
The actual work for making inductive variable detection better is #40502 . There's already one CL for that, but if you're interested in the prove code there might be other improvements to be had. Or look at other prove improvement issues.
Thanks for the update. I'll pickup a issue from the link you provide
…there is no direct edge from if block to phi block Currently in addLocalInductiveFacts, we only check whether direct edge from if block to phi block exists. If not, the following logic will treat the phi block as the first successor, which is wrong. This patch makes prove pass more conservative, so we disable some cases in test/prove.go. We will do some optimization in the following CL and enable these cases then. Fixes #40500. Change-Id: I27cf0248f3a82312a6f7dabe11c79a1a34cf5412 Reviewed-on: https://go-review.googlesource.com/c/go/+/244579 Reviewed-by: Zach Jones <firstname.lastname@example.org> Reviewed-by: Keith Randall <email@example.com> Run-TryBot: Keith Randall <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-on: https://go-review.googlesource.com/c/go/+/245957 Reviewed-by: David Chase <firstname.lastname@example.org> Reviewed-by: Carlos Amedee <email@example.com>