Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: improve implementation of OFORUNTIL inductive fact detection #40502

Open
randall77 opened this issue Jul 30, 2020 · 2 comments
Open

Comments

@randall77
Copy link
Contributor

@randall77 randall77 commented Jul 30, 2020

This issue is for followon improvements to #40367. We had to disable some optimizations for that issue, which we should reenable/improve for 1.16.
@choleraehyq @zdjones @dr2chase @cherrymui

@randall77 randall77 added this to the Go1.16 milestone Jul 30, 2020
@choleraehyq
Copy link
Contributor

@choleraehyq choleraehyq commented Jul 31, 2020

I’ll do the isSameOrPlainSuccessor optimization and reenable these two test cases later.

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 31, 2020

Change https://golang.org/cl/246157 mentions this issue: cmd/compile: check indirect connection between if block and phi block in addLocalInductiveFacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.