Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: 3 of 6 corellium iOS and Android builders are missing #40523

Closed
dmitshur opened this issue Jul 31, 2020 · 8 comments
Closed

x/build: 3 of 6 corellium iOS and Android builders are missing #40523

dmitshur opened this issue Jul 31, 2020 · 8 comments

Comments

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Jul 31, 2020

From https://farmer.golang.org#pools:

  • host-android-arm64-corellium-android: 0/0 (3 missing)
  • host-darwin-arm64-corellium-ios: 0/0 (3 missing)

Their results have stopped showing up on https://build.golang.org since around Jul 17.

/cc @znly per builder owners. Are you able to take a look at this? Thanks.

/cc @cagedmantis @toothrot @andybons

@dmitshur
Copy link
Contributor Author

@dmitshur dmitshur commented Aug 19, 2020

These builders were added in #31722. Perhaps @znly isn't the best GitHub account to ping about this, because it's an organization.

/cc @eliasnaur @bradfitz @steeve Do you know who would be a good person to ping to look into this issue? Thank you.

Loading

@eliasnaur
Copy link
Contributor

@eliasnaur eliasnaur commented Aug 19, 2020

All the builders were turned off at Corellium. Perhaps someone on the Go team would like access to the Corellium dashboard for when it happens in the future? I'm not actively checking the build.golang.org dashboard.

Loading

@steeve
Copy link
Contributor

@steeve steeve commented Aug 19, 2020

Let me know if you need to add people to the org.

On a side note, I see the results are back.

Loading

@dmitshur
Copy link
Contributor Author

@dmitshur dmitshur commented Aug 19, 2020

Thank you for looking at this issue. I see that some of the builders are back, although it seems to be 3 out of 6 in total so far:

host-android-arm64-corellium-android: 1/1 (2 missing)
host-darwin-arm64-corellium-ios: 0/2 (1 missing)

I think it's helpful to have more clarity about the builder owner. We do keep an eye on the build dashboard regularly, so it's okay if you don't do it. As long as we're able to reach the builder owner when we spot an issue, then us not having access is okay. If this happens more often, we can can revisit this.

Please let us know if you think we should change the current builder owner entry (this line) to something that's better for the future.

Loading

@dmitshur dmitshur changed the title x/build: corellium iOS and Android builders are missing x/build: 3 of 6 corellium iOS and Android builders are missing Aug 19, 2020
@eliasnaur
Copy link
Contributor

@eliasnaur eliasnaur commented Aug 19, 2020

Thank you for looking at this issue. I see that some of the builders are back, although it seems to be 3 out of 6 in total so far:

host-android-arm64-corellium-android: 1/1 (2 missing)
host-darwin-arm64-corellium-ios: 0/2 (1 missing)

FWIW, there are only two Android corellium hosts and two iOS corellium hosts.

I think it's helpful to have more clarity about the builder owner. We do keep an eye on the build dashboard regularly, so it's okay if you don't do it. As long as we're able to reach the builder owner when we spot an issue, then us not having access is okay. If this happens more often, we can can revisit this.

Please let us know if you think we should change the current builder owner entry (this line) to something that's better for the future.

I'd love someone on the Go team could do the resetting, which means someone should have access to the Corellium dashboard. I'm also ok doing the infrequent manual restarts.

Ideally, there should be external monitoring of Corellium and automatic restarts. Corellium is not really built for continuous integration. There's an ongoing lawsuit where Apple is trying to shut Corellium down, so motivation is low :)

Loading

@dmitshur
Copy link
Contributor Author

@dmitshur dmitshur commented Aug 19, 2020

FWIW, there are only two Android corellium hosts and two iOS corellium hosts.

I see. That means we can update ExpectNum accordingly.

I'd love someone on the Go team could do the resetting, which means someone should have access to the Corellium dashboard. I'm also ok doing the infrequent manual restarts.

Ideally, there should be external monitoring of Corellium and automatic restarts. Corellium is not really built for continuous integration. There's an ongoing lawsuit where Apple is trying to shut Corellium down, so motivation is low :)

Thanks for explaining.

Would you be able to send a CL adding a README https://github.com/golang/build/tree/master/env/corellium with a description of how to do the resets?

I'll close this issue since the builders are back. Thanks again.

Loading

@dmitshur dmitshur closed this Aug 19, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 19, 2020

Change https://golang.org/cl/249337 mentions this issue: dashboard: update expected number of corellium builders

Loading

gopherbot pushed a commit to golang/build that referenced this issue Aug 19, 2020
According to https://golang.org/issue/40523#issuecomment-676546824,
there are only 2 Android corellium hosts and 2 iOS corellium hosts.

Also add links to issues with more information to the builder notes.

Updates golang/go#40523.
Updates golang/go#31722.

Change-Id: Ibabccebfcc6735cba867cccf109c71607223d1a2
Reviewed-on: https://go-review.googlesource.com/c/build/+/249337
Reviewed-by: Carlos Amedee <carlos@golang.org>
@eliasnaur
Copy link
Contributor

@eliasnaur eliasnaur commented Aug 19, 2020

Would you be able to send a CL adding a README https://github.com/golang/build/tree/master/env/corellium with a description of how to do the resets?

Sure: https://go-review.googlesource.com/c/build/+/249358

Loading

@golang golang locked and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants