Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: Add copyright title to file #40540

Closed
QiangHeisenberg opened this issue Aug 3, 2020 · 2 comments
Closed

all: Add copyright title to file #40540

QiangHeisenberg opened this issue Aug 3, 2020 · 2 comments
Labels

Comments

@QiangHeisenberg
Copy link
Contributor

@QiangHeisenberg QiangHeisenberg commented Aug 3, 2020

Some files lack copyright titles, do they not need to be added? Or is copyright restricted? In addition, I want to know how the year is determined.

Files lacking copyright titles such as:
src/runtime/pprof/internal/profile/proto_test.go
src/runtime/pprof/label.go
src/runtime/defs_linux_arm.go
src/runtime/defs_linux_arm64.go
src/runtime/defs_linux_amd64.go
...
There are a lot more. Need to add? I am very happy to do this job. Thank you.

@davecheney
Copy link
Contributor

@davecheney davecheney commented Aug 3, 2020

src/runtime/pprof/internal/profile/proto_test.go

This file does not appear to exist at head

src/runtime/pprof/label.go

This file carries a copyright message at head

src/runtime/defs_linux_arm.go

This file requires a copyright header, I cannot advise you on the correct date, I suggest making your best guess and discussing it in code review.

src/runtime/defs_linux_arm64.go

This file may be auto generated according to the current comment.

src/runtime/defs_linux_amd64.go

ditto

/cc @dmitshur

@QiangHeisenberg
Copy link
Contributor Author

@QiangHeisenberg QiangHeisenberg commented Aug 3, 2020

thank you, @davecheney ,Thank you for your reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.