Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/go: regression in behavior of DepsErrors #40544
The behavior of the DepsErrors field in the output of
In GOPATH-mode, have two packages
the ImportStack would clearly indicate that this issue occurs in the sandbox/bar package.
However, running the same command with tip (f923374) produces the following output:
Only add files in errors if either the error's import stack is empty, or the import stack's top package is the same as the package itself, so we have more confidence that the error applies to the package. This is bound to be flaky, but shouldn't be worse than the current state. (And it unblocks a cl from going into the RC...). Updates golang/go#40544 Change-Id: Ie21a8abec7150800d3d34b94a7ec90fd40d93fe9 Reviewed-on: https://go-review.googlesource.com/c/tools/+/246758 Run-TryBot: Michael Matloob <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-by: Rebecca Stambler <firstname.lastname@example.org>