Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: remove autocomplete experiment code #40549

Open
andybons opened this issue Aug 3, 2020 · 2 comments
Open

x/pkgsite: remove autocomplete experiment code #40549

andybons opened this issue Aug 3, 2020 · 2 comments

Comments

@andybons
Copy link
Member

@andybons andybons commented Aug 3, 2020

Given the code churn on the homepage and header, autocomplete no longer works when turned on. As far as I know, no one is actively maintaining it. We should remove the code until we are ready to launch it to users.

@julieqiu julieqiu added NeedsInvestigation and removed NeedsFix labels Aug 3, 2020
@dmitshur dmitshur changed the title pkgsite: remove autocomplete experiment code x/pkgsite: remove autocomplete experiment code Aug 3, 2020
@gopherbot gopherbot added this to the Unreleased milestone Aug 3, 2020
@findleyr
Copy link
Contributor

@findleyr findleyr commented Aug 3, 2020

I can get this working again, when we're ready to launch.

We can wait until the header code stabilizes, but if that has already happened I'd be happy to fix it rather than remove it.

@andybons
Copy link
Member Author

@andybons andybons commented Aug 3, 2020

@findleyr sgtm!

@findleyr findleyr self-assigned this Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.