Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/go1.15: add note about crypto/tls error wrapping change #40554

Closed
rolandshoemaker opened this issue Aug 3, 2020 · 2 comments
Closed

doc/go1.15: add note about crypto/tls error wrapping change #40554

rolandshoemaker opened this issue Aug 3, 2020 · 2 comments
Assignees
Milestone

Comments

@rolandshoemaker
Copy link
Member

@rolandshoemaker rolandshoemaker commented Aug 3, 2020

After https://go-review.googlesource.com/c/go/+/227840 http.Client and tls.Client will now return an opaque tls.permanentError in place of what were previously public error types (i.e. net.OpErr). This means that in order to get the previously top level error users need to use errors.As (or errors.Unwrap) to get the useful error (best practice should presumably be to always use errors.As but directly casting to net.OpErr is definitely quite common).

cc @FiloSottile @katiehockman

@katiehockman
Copy link
Member

@katiehockman katiehockman commented Aug 10, 2020

Yeah that sounds good. I'll take care of that. Thanks @rolandshoemaker.

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 10, 2020

Change https://golang.org/cl/247698 mentions this issue: docs/go1.15: document crypto/tls permanentError

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.