Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: make better use of horizontal space #40557

Closed
andybons opened this issue Aug 3, 2020 · 5 comments
Closed

x/pkgsite: make better use of horizontal space #40557

andybons opened this issue Aug 3, 2020 · 5 comments

Comments

@andybons
Copy link
Member

@andybons andybons commented Aug 3, 2020

With the new side navigation changes launched for documentation, we aren’t taking advantage of the amount of horizontal space we have (especially on wider viewports). This is to track investigating alternatives so that we can better use the space available.

https://stripe.com/docs/api does this rather well in my opinion.

@gopherbot gopherbot added this to the Unreleased milestone Aug 3, 2020
@julieqiu julieqiu added the UX label Aug 4, 2020
@salewski
Copy link

@salewski salewski commented Aug 6, 2020

It would be nice if something could be done to prevent the horizontal scrollbars and truncated content, as can be seen in the first screenshot below.

The page of the first screenshot is:

The page in the first screenshot is at 100% zoom, in chromium.

User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.116 Safari/537.36

Despite there being tons of unused space on both sides of the page, the main content is still truncated. While I appreciate that overly wide columns of text are difficult to read, having the data truncated and needing to side-scroll -- especially multiple individual things to side-scroll -- is always worse.

screenshot-horiz-scrolling

For the sake of comparison, below is a screenshot of that content on godoc.org, on the page:

There is less information displayed vertically, but none of it is truncated:

screenshot-godoc org

@mholt
Copy link

@mholt mholt commented Aug 7, 2020

Just found this, but also made a related comment at #40612 (comment)

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 18, 2020

Change https://golang.org/cl/248857 mentions this issue: content/static,internal: allow fluid width for documentation

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Aug 19, 2020

In case anyone missed it, mocks for the CL above are at #40612 (comment)

@tooolbox
Copy link

@tooolbox tooolbox commented Aug 21, 2020

For the sake of comparison, below is a screenshot of that content on godoc.org, on the page:

There is less information displayed vertically, but none of it is truncated:

I believe that part of the truncation going on is due to the overall increased font sizes. /grump

😉

I am curious how golang/pkgsite@47151e4 will affect things, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants