x/build/internal/releasetargets: evaluate for each upcoming major Go release #40561

dmitshur · 2020-08-04T03:36:08Z

At the start of each code freeze, we should evaluate the choice of releaselets (builders that are used for constructing a release artifact) used to make the upcoming major Go release, and confirm they are the most appropriate choice out of what is available.

The start of a code freeze is a safe time to introduce a builder change, as it will be tested during pre-release versions, starting with beta 1 and onwards.

Making this a release blocker for Go 1.16 (and not okay after beta 1—it needs to be done before). Once completed, this issue should be moved to the next major release milestone.

Edit: Starting with Go 1.21, releaselets are only used for running tests. Release artifact construction happens by reproducibly cross-compiling a distpack distribution on a fixed builder.

CC @golang/release, @ianlancetaylor.

toothrot · 2020-11-05T19:16:06Z

/cc @cagedmantis

dmitshur · 2020-11-21T01:18:21Z

The @golang/release team has considered the current builders, and we are proposing the following builder changes for the Go 1.16 release:

go1.16*.linux-amd64.tar.gz

	Builder Name	Host Type
Current	linux-amd64-jessie	host-linux-jessie
New	linux-amd64	host-linux-stretch

(Or rather a new builder, identical to the linux-amd64 one, just named linux-amd64-stretch instead.)

Rationale: Debian 8 "Jessie" Long Term Support (LTS) has ended on June 30, 2020 (see https://wiki.debian.org/LTS). We want to start using the next stable release, Debian 9 "Stretch", which has LTS support until June 2022.

Note that this has caused #31293 in April 2019 when this change was made unintentionally as part of a minor release, and it was reverted. We hope that it should be okay to try again for Go 1.16 a year later, since this is being done intentionally this time, and for a major release. CC @ianlancetaylor, @jayconrod, @bradfitz.

go1.16*.linux-386.tar.gz

	Builder Name	Host Type
Current	linux-386	host-linux-jessie
New	linux-386-stretch	host-linux-stretch

Rationale: Same as the one above for linux/amd64.

go1.16*.linux-armv6l.tar.gz

	Builder Name	Host Type
Current	linux-arm	host-linux-arm-scaleway
New	linux-arm-aws	host-linux-arm-aws

Rationale: The replacement builder has proven to be more reliable, and it is easier for us to maintain.

go1.16*.linux-arm64.tar.gz

	Builder Name	Host Type
Current	linux-arm64-packet	host-linux-arm64-packet
New	linux-arm64-aws	host-linux-arm64-aws

Rationale: The replacement builder has proven to be more reliable, and it is easier for us to maintain.

Also see #42304 (comment).

Feedback is welcome: we are happy to alter the plan based on information we haven't already considered. These builder changes are planned for Go 1.16 Beta 1, and we will re-evaluate this as needed based on any new findings and feedback.

gopherbot · 2020-12-08T04:08:51Z

Change https://golang.org/cl/276034 mentions this issue: cmd/release, dashboard: implement builder plan for Go 1.16

See https://golang.org/issues/40561#issuecomment-731482962 for the plan description and rationale. Add new builder definitions that are needed for the plan. Don't rely on generic builder name like "linux-amd64" to avoid a repeat of golang.org/issue/31293; use a specific builder name instead. Remove support and test cases for Go 1.13, it's unsupported per release policy. For golang/go#40561. Change-Id: I070744e15be9f1932d649a27ee7e4599e467553f Reviewed-on: https://go-review.googlesource.com/c/build/+/276034 Trust: Dmitri Shuralyov <dmitshur@golang.org> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org>

dmitshur · 2020-12-09T05:08:19Z

CL 276034 has implemented the aforementioned plan for Go 1.16.

We'll need to revisit this issue next time during the Go 1.17 development cycle. (If we discover problems with the Go 1.16 plan, we'll come back here, or file new issues.) Moving to the next milestone for now.

thanm · 2020-12-15T14:59:49Z

While working on issue #39326, it has become clear to me that the C compile we have installed on our windows gomotes (at least the ones I have used) is pretty ancient -- GCC 5. It would be great if we could update the version to something a bit more recent (V10 maybe). Also worth noting that many folks are now using clang instead of gcc on windows -- it would be great if our gomotes had clang available as well.

dmitshur · 2020-12-15T15:30:14Z

@thanm Can you please file a separate issue to track that work, and CC @golang/release? It may need more information/investigation. Thanks.

thanm · 2020-12-15T16:13:04Z

Filed #43195. Thanks.

gopherbot · 2020-12-15T17:22:29Z

Change https://golang.org/cl/278357 mentions this issue: cmd/release: update checkRelocations for Go 1.16

The plan in https://golang.org/issue/40561#issuecomment-731482962 involved updating the linux-amd64 target from Debian Jessie to Debian Stretch, which in turn comes with a newer version of GCC. checkRelocations was added in CL 171317 in response to a bad minor release that was accidentally issued without the intended fix, and needs to be updated for Go 1.16 and newer releases. It's not clear if we want to maintain it indefinitely for future Go versions, but keep it for a bit longer. Add a note to make it clear that it can be removed as needed in the future. For golang/go#40561. Updates golang/go#31293. Change-Id: I2da419eff6379575eb2648787f0dac6bba07b304 Reviewed-on: https://go-review.googlesource.com/c/build/+/278357 Trust: Dmitri Shuralyov <dmitshur@golang.org> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Alexander Rakoczy <alex@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org>

gopherbot · 2021-04-23T17:00:26Z

Change https://golang.org/cl/313070 mentions this issue: dashboard: make FreeBSD 11.4 and 12.2 builders the default

With this change: - The default FreeBSD builders used on master are 11.4 and 12.2. - The FreeBSD 12.0 builders have been removed. - The FreeBSD 11.2 builders have been set to run on at most Go 1.16. They will continue to be used for Go 1.16.x and 1.15.x minor releases. - The freebsd-amd64-race builder has been updated to use the FreeBSD 12.2 host. - The slowbot aliases for FreeBSD have been updated to use 12.2. Fixes golang/go#44431 Update golang/go#45727 Update golang/go#40561 Change-Id: Ib558fca65c2de1916b4633711d3e320c390bd2b2 Reviewed-on: https://go-review.googlesource.com/c/build/+/313070 Trust: Carlos Amedee <carlos@golang.org> Run-TryBot: Carlos Amedee <carlos@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>

cagedmantis · 2021-04-30T22:02:20Z

The @golang/release team has considered the current builders, and we are proposing the following builder change for the Go 1.17 release:

go1.17.*.freebsd-amd64.tar.gz

	Builder Name	Host Type
Current	freebsd-amd64-11_2	host-freebsd-11_2
New	freebsd-amd64-11_4	host-freebsd-11_4

Rationale: Using the latest "patch" release of the oldest supported "major" release of FreeBSD.

#45727 (comment)

go1.17.*.freebsd-386.tar.gz

	Builder Name	Host Type
Current	freebsd-386-11_2	host-freebsd-11_2
New	freebsd-386-11_4	host-freebsd-11_4

Rationale: Using the latest "patch" release of the oldest supported "major" release of FreeBSD.

#45727 (comment)

gopherbot · 2021-04-30T22:03:30Z

Change https://golang.org/cl/315889 mentions this issue: cmd/release: start using the FreeBSD 11.4 builder for Go 1.17

gopherbot · 2022-10-26T18:25:47Z

Change https://go.dev/cl/445619 mentions this issue: dashboard,internal/releasetargets: target Bullseye for Go 1.20

For golang/go#56414, golang/go#40561. Change-Id: If799e9ea7171d33acc57c53442ca33f51f803d3c Reviewed-on: https://go-review.googlesource.com/c/build/+/445619 Auto-Submit: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org>

gopherbot · 2022-11-15T15:55:07Z

Change https://go.dev/cl/449615 mentions this issue: all: replace linux-arm64-aws with linux-arm64

This change replaces linux-arm64-aws with linux-arm64. The new builder runs on GCP and has an increased set of resources. This should provide a performance improvement. The builder will now be used: - To release linux-arm64 - As the linux-arm64 trybot Fixes golang/go#53851 Updates golang/go#54679 Updates golang/go#40561 Change-Id: I9abfe2ed1d1bd8a68bba1e1f924637e829026e6d Reviewed-on: https://go-review.googlesource.com/c/build/+/449615 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Run-TryBot: Carlos Amedee <carlos@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Jenny Rakoczy <jenny@golang.org>

gopherbot · 2022-11-29T18:46:57Z

Change https://go.dev/cl/453956 mentions this issue: dashboard,internal/releasetargets: run AMD64 Macs AWS, build 1.20 with 13

…h 13 The AWS builders have been up and running reliably for a while now. Switch over. Unfortunately the macOS 13 builder had -aws in its name, so we're creating a new builder and will need a backfill. So it goes. While I'm here, build 1.20 with 13 now that we have it. For golang/go#48945, golang/go#40561. Change-Id: Idaac9cfea6fe3f5e190432ecb512a453812618c7 Reviewed-on: https://go-review.googlesource.com/c/build/+/453956 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Auto-Submit: Heschi Kreinick <heschi@google.com>

heschi · 2022-12-02T19:36:09Z

Current state of affairs is visible at https://cs.opensource.google/go/x/build/+/master:internal/releasetargets/releases.txt;l=105;drc=14add1f2a409547572304844b265b007589d3c16.

Linux: We've updated most of the linux builders to Bullseye, but I suspect not arm-aws, and I'm not sure of the state of arm on GCE (@cagedmantis).

macOS: We've updated AMD64 to 13, but don't have an ARM64 13 builder yet. That's slightly unfortunate but I don't think it's a major problem.

Windows: seems like we want to be on 2008 for as long as that's our minimum supported version?

FreeBSD: should probably be updated to 13.

Anything I'm missing?

cagedmantis · 2022-12-02T20:45:44Z

linux-arm-aws is currently on Buster. We do not have immediate plans to deploy a replacement on GCE nor do we plan to update the current image.

gopherbot · 2022-12-02T22:17:26Z

Change https://go.dev/cl/454936 mentions this issue: internal/releasetargets: use FreeBSD 13 for Go 1.20

heschi · 2022-12-02T22:18:45Z

Nothing else to do this cycle, bumping.

For golang/go#40561. Change-Id: Ideb41ea0ce6a2340fee6d98bf5672e361db81532 Reviewed-on: https://go-review.googlesource.com/c/build/+/454936 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Heschi Kreinick <heschi@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Heschi Kreinick <heschi@google.com>

heschi · 2023-05-16T19:50:27Z

Linux: bullseye is still the latest version. linux-arm-aws is still behind and we're still okay with it.
macOS: 13 is still the latest version, so we're good on AMD64 and still behind on ARM64. I think we're still okay with it.
Windows: we've dropped support for Windows 8 -- we need to target windows-386/amd64-2016. Windows 11 is still the most recent major version on ARM64, though it's an old patch level by now.
FreeBSD: should perhaps be updated to 13.2 but it's a second-class port and not our problem.

gopherbot · 2023-05-16T19:59:25Z

Change https://go.dev/cl/495317 mentions this issue: internal/releasetargets: target Windows 2016

We dropped support for 7 (aka 2008) and 8 this cycle. For golang/go#40561. Change-Id: Iceca7bf866c94587450a9716155fe42aa0ca4d3b Reviewed-on: https://go-review.googlesource.com/c/build/+/495317 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Auto-Submit: Heschi Kreinick <heschi@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com>

heschi · 2023-05-16T21:36:24Z

Done for this cycle.

gopherbot · 2023-06-15T14:56:39Z

Change https://go.dev/cl/503755 mentions this issue: internal/releasetargets: drop Go 1.18 targets

gopherbot · 2023-06-15T14:56:40Z

Change https://go.dev/cl/503758 mentions this issue: internal/releasetargets: set LongTestBuilder for darwin-amd64

gopherbot · 2023-06-15T14:56:42Z

Change https://go.dev/cl/503756 mentions this issue: internal/releasetargets: regenerate all ports for Go 1.21

There won't be new Go 1.18 releases per go.dev/doc/devel/release#policy. For golang/go#40561. Change-Id: Id9c34368e97143198419fdbf75c8fcfbf853e6ab Reviewed-on: https://go-review.googlesource.com/c/build/+/503755 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org>

It's a no-op since the only newly added port is wasip1/wasm, and we won't be making binary releases for it at this time. For golang/go#40561. For golang/go#58141. Change-Id: I0c9932fdfca0842c6860bca0cdbc4b1d64fdefff Reviewed-on: https://go-review.googlesource.com/c/build/+/503756 Reviewed-by: Heschi Kreinick <heschi@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org>

A longtest builder for the darwin/amd64 port was added in the Go 1.21 development cycle. Start using it as for non-advisory release testing. For golang/go#40561. For golang/go#35678. For golang/go#29252. Change-Id: Ic65e84e5e10bcb786cb28c36c1d1b137e2f6202e Reviewed-on: https://go-review.googlesource.com/c/build/+/503758 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Heschi Kreinick <heschi@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>

gopherbot · 2023-06-20T12:33:31Z

Change https://go.dev/cl/504525 mentions this issue: internal/releasetargets: set LongTestBuilder for linux-arm64

The linux/arm64 port is first class and a longtest builder was added for it during the Go 1.20 development cycle. It's a mandatory trybot on 1.20+ release branches and is working well. The builder recently found a real problem in go.dev/issue/60825, which has been resolved by now. Upgrade this builder from an advisory TryBot to have more complete release test coverage. For golang/go#40561. For golang/go#49649. For golang/go#29252. Change-Id: I1765e820deb0d34b7bb9a72aba397d87c1369ced Reviewed-on: https://go-review.googlesource.com/c/build/+/504525 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>

gopherbot · 2023-09-08T18:17:09Z

Change https://go.dev/cl/527017 mentions this issue: internal/releasetargets: drop Go 1.19 targets

There won't be new Go 1.19 releases per go.dev/doc/devel/release#policy. For golang/go#62076. For golang/go#40561. Change-Id: I30e09c9f47ec0006caeb67e15e03b8cdbff7c175 Reviewed-on: https://go-review.googlesource.com/c/build/+/527017 Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Carlos Amedee <carlos@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>

dmitshur added Builders x/build issues (builders, bots, dashboards) release-blocker recurring Issues that should never be closed, but moved to the next milestone once fixed in the current one. labels Aug 4, 2020

dmitshur added this to the Go1.16 milestone Aug 4, 2020

dmitshur mentioned this issue Aug 4, 2020

x/build/cmd/release: update to freebsd-{amd64,386}-11_2 builder for 1.15 RC 2+ #40563

Closed

toothrot added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Aug 4, 2020

dmitshur mentioned this issue Oct 30, 2020

x/build/env/linux-arm64/packet: 8 Packet linux/arm64 machines missing (late-October 2020) #42304

Closed

dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Nov 19, 2020

dmitshur self-assigned this Dec 3, 2020

dmitshur modified the milestones: Go1.16, Go1.17 Dec 9, 2020

dmitshur removed their assignment Dec 9, 2020

dmitshur changed the title ~~x/build/cmd/release: evaluate builders used for upcoming major Go release~~ x/build/cmd/release: evaluate releaselets used for each upcoming major Go release Dec 15, 2020

dmitshur mentioned this issue Dec 15, 2020

x/build/cmd/release: linux-armv6l release tests aren't passing #43202

Closed

dmitshur mentioned this issue Jan 29, 2021

x/build: document that Ubuntu 14.04 doesn't meet minimum requirement for Go 1.16 binary release #43996

Closed

heschi modified the milestones: Go1.20, Go1.21 Dec 2, 2022

dmitshur changed the title ~~x/build/cmd/release: evaluate releaselets used for each upcoming major Go release~~ x/build/internal/releasetargets: evaluate for each upcoming major Go release Feb 23, 2023

heschi modified the milestones: Go1.21, Go1.22 May 16, 2023

x/build/internal/releasetargets: evaluate for each upcoming major Go release #40561

x/build/internal/releasetargets: evaluate for each upcoming major Go release #40561

dmitshur commented Aug 4, 2020 •

edited

toothrot commented Nov 5, 2020

dmitshur commented Nov 21, 2020 •

edited

gopherbot commented Dec 8, 2020

dmitshur commented Dec 9, 2020

thanm commented Dec 15, 2020

dmitshur commented Dec 15, 2020 •

edited

thanm commented Dec 15, 2020

gopherbot commented Dec 15, 2020

gopherbot commented Apr 23, 2021

cagedmantis commented Apr 30, 2021

gopherbot commented Apr 30, 2021

gopherbot commented Oct 26, 2022

gopherbot commented Nov 15, 2022

gopherbot commented Nov 29, 2022

heschi commented Dec 2, 2022

cagedmantis commented Dec 2, 2022

gopherbot commented Dec 2, 2022

heschi commented Dec 2, 2022

heschi commented May 16, 2023

gopherbot commented May 16, 2023

heschi commented May 16, 2023

gopherbot commented Jun 15, 2023

gopherbot commented Jun 15, 2023

gopherbot commented Jun 15, 2023

gopherbot commented Jun 20, 2023

gopherbot commented Sep 8, 2023

x/build/internal/releasetargets: evaluate for each upcoming major Go release #40561

x/build/internal/releasetargets: evaluate for each upcoming major Go release #40561

Comments

dmitshur commented Aug 4, 2020 • edited

toothrot commented Nov 5, 2020

dmitshur commented Nov 21, 2020 • edited

go1.16*.linux-amd64.tar.gz

go1.16*.linux-386.tar.gz

go1.16*.linux-armv6l.tar.gz

go1.16*.linux-arm64.tar.gz

gopherbot commented Dec 8, 2020

dmitshur commented Dec 9, 2020

thanm commented Dec 15, 2020

dmitshur commented Dec 15, 2020 • edited

thanm commented Dec 15, 2020

gopherbot commented Dec 15, 2020

gopherbot commented Apr 23, 2021

cagedmantis commented Apr 30, 2021

go1.17.*.freebsd-amd64.tar.gz

go1.17.*.freebsd-386.tar.gz

gopherbot commented Apr 30, 2021

gopherbot commented Oct 26, 2022

gopherbot commented Nov 15, 2022

gopherbot commented Nov 29, 2022

heschi commented Dec 2, 2022

cagedmantis commented Dec 2, 2022

gopherbot commented Dec 2, 2022

heschi commented Dec 2, 2022

heschi commented May 16, 2023

gopherbot commented May 16, 2023

heschi commented May 16, 2023

gopherbot commented Jun 15, 2023

gopherbot commented Jun 15, 2023

gopherbot commented Jun 15, 2023

gopherbot commented Jun 20, 2023

gopherbot commented Sep 8, 2023

dmitshur commented Aug 4, 2020 •

edited

dmitshur commented Nov 21, 2020 •

edited

dmitshur commented Dec 15, 2020 •

edited