Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: freebsd-amd64-race builder should be updated to use a newer FreeBSD version #40562

Open
dmitshur opened this issue Aug 4, 2020 · 2 comments

Comments

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Aug 4, 2020

The freebsd-amd64-race builder currently uses host-freebsd-11_1-big. Go 1.13 and newer require FreeBSD 11.2 or newer. We should update this builder accordingly.

If our assumption is that newer stable releases of FreeBSD have fewer bugs, we should likely use the latest stable version we have a builder for, since the goal of a -race builder is to catch data races in the Go code.

/cc @toothrot @cagedmantis @andybons

@dmitshur dmitshur added this to the Unreleased milestone Aug 4, 2020
gopherbot pushed a commit to golang/build that referenced this issue Aug 4, 2020
These builders are still used for making minor Go 1.14 and 1.13
releases at this time (see golang.org/issue/40563). Re-enable
them on relevant release branches so that we are better informed
for future minor releases.

For golang/go#40563.
Updates golang/go#40562.

Change-Id: I20a6becbdb1078b92dbf6042edca7f482bca6432
Reviewed-on: https://go-review.googlesource.com/c/build/+/246638
Reviewed-by: Carlos Amedee <carlos@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 4, 2020

Change https://golang.org/cl/246638 mentions this issue: dashboard: re-enable FreeBSD 11.1 builders on Go 1.14 and 1.13

@paulzhol
Copy link
Member

@paulzhol paulzhol commented Aug 28, 2020

@dmitshur I've updated env/freebsd-amd64 to allow building a 11.3-RELEASE images in https://golang.org/cl/186038.
I should also test and add a 11.4-RELEASE and 12.1-RELEASE now, with 12.2 due in two months. I can't create the images though, brad used to do it I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.