Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: freebsd-amd64-race builder should be updated to use a newer FreeBSD version #40562

Closed
dmitshur opened this issue Aug 4, 2020 · 8 comments

Comments

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Aug 4, 2020

The freebsd-amd64-race builder currently uses host-freebsd-11_1-big. Go 1.13 and newer require FreeBSD 11.2 or newer. We should update this builder accordingly.

If our assumption is that newer stable releases of FreeBSD have fewer bugs, we should likely use the latest stable version we have a builder for, since the goal of a -race builder is to catch data races in the Go code.

/cc @toothrot @cagedmantis @andybons

@dmitshur dmitshur added this to the Unreleased milestone Aug 4, 2020
gopherbot pushed a commit to golang/build that referenced this issue Aug 4, 2020
These builders are still used for making minor Go 1.14 and 1.13
releases at this time (see golang.org/issue/40563). Re-enable
them on relevant release branches so that we are better informed
for future minor releases.

For golang/go#40563.
Updates golang/go#40562.

Change-Id: I20a6becbdb1078b92dbf6042edca7f482bca6432
Reviewed-on: https://go-review.googlesource.com/c/build/+/246638
Reviewed-by: Carlos Amedee <carlos@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 4, 2020

Change https://golang.org/cl/246638 mentions this issue: dashboard: re-enable FreeBSD 11.1 builders on Go 1.14 and 1.13

@paulzhol
Copy link
Member

@paulzhol paulzhol commented Aug 28, 2020

@dmitshur I've updated env/freebsd-amd64 to allow building a 11.3-RELEASE images in https://golang.org/cl/186038.
I should also test and add a 11.4-RELEASE and 12.1-RELEASE now, with 12.2 due in two months. I can't create the images though, brad used to do it I think.

@gopherbot
Copy link

@gopherbot gopherbot commented Dec 20, 2020

Change https://golang.org/cl/279392 mentions this issue: env/freebsd-amd64: add FreeBSD 11.4, 12.1, 12.2 images

@problame
Copy link

@problame problame commented Feb 15, 2021

@paulzhol What is the timeline for landing the 12.2 builder? I have reason to believe that there has been a regression in the Go runtime that leads to crashes starting with FreeBSD 12.2 ( #43873 ).

@paulzhol
Copy link
Member

@paulzhol paulzhol commented Feb 17, 2021

@problame I can't create the images in the project's internal GCP account. Ping @dmitshur, @cagedmantis now that Go 1.16 is out maybe there's more time to add the builders.
Also FreeBSD 13.0 will be released in about a month now.

@dmitshur
Copy link
Contributor Author

@dmitshur dmitshur commented Feb 19, 2021

For now I'll resolve this specific issue by updating freebsd-amd64-race to use the latest available FreeBSD version, 12.0.

Please file a separate issue about adding new builders that target newer versions of FreeBSD. Thank you.

@dmitshur dmitshur self-assigned this Feb 19, 2021
@dmitshur dmitshur added this to In Progress in Go Release Team Feb 19, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Feb 19, 2021

Change https://golang.org/cl/293771 mentions this issue: dashboard: remove builders that are unused as of Go 1.16 release

@paulzhol
Copy link
Member

@paulzhol paulzhol commented Feb 19, 2021

Thanks @dmitshur, I've opened #44431.

@gopherbot gopherbot closed this in 43ea694 Feb 19, 2021
Go Release Team automation moved this from In Progress to Done Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants