Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: tabs doc, versions, imports and imported should be disabled for directory page #40571

Closed
julieqiu opened this issue Aug 4, 2020 · 1 comment
Assignees
Labels
Milestone

Comments

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Aug 4, 2020

On a directory page, such as https://pkg.go.dev/github.com/elastic/beats, only these tabs should be enabled:

  • Overview
  • Subdirectories
  • Licenses

At the moment, all of the tabs are enabled, both in the main header and the sticky header.

image

image

The logic for which tabs to enable on each page is in internal/frontend/tabs.go.

/cc @andybons

@gopherbot gopherbot added this to the Unreleased milestone Aug 4, 2020
@andybons andybons self-assigned this Aug 4, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 4, 2020

Change https://golang.org/cl/246760 mentions this issue: content/static: properly disable details tabs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants