Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/xerrors: tests broken (via vet error) with go1.15rc1 [1.15 backport] #40573

Closed
gopherbot opened this issue Aug 4, 2020 · 3 comments
Closed

x/xerrors: tests broken (via vet error) with go1.15rc1 [1.15 backport] #40573

gopherbot opened this issue Aug 4, 2020 · 3 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 4, 2020

@bcmills requested issue #40536 to be considered for backport to the next 1.15 minor release.

@gopherbot, please backport to 1.15.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Aug 6, 2020

Change https://golang.org/cl/247217 mentions this issue: [release-branch.go1.15] xerrors: avoid infinite loop in test (detailed).Error method

gopherbot pushed a commit to golang/xerrors that referenced this issue Aug 6, 2020
…d).Error method

For golang/go#40573

Change-Id: I5daaec48301cdedb2efcfadaf1dcd41cb8e96b01
Reviewed-on: https://go-review.googlesource.com/c/xerrors/+/246640
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
(cherry picked from commit 5ec99f8)
Reviewed-on: https://go-review.googlesource.com/c/xerrors/+/247217
Run-TryBot: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Aug 6, 2020

Closed by merging 1a77d5e9f316d6917d88a497ab4db07399cbc923 to release-branch.go1.15.

@gopherbot gopherbot closed this Aug 6, 2020
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Aug 6, 2020

Change https://golang.org/cl/247186 mentions this issue: cmd: update golang.org/x/xerrors

gopherbot pushed a commit that referenced this issue Aug 6, 2020
This pulls in CL 247217.

Fixes #40573

Change-Id: I89eeebb5da9a4668adc6b5c5155651e5da421d59
Reviewed-on: https://go-review.googlesource.com/c/go/+/247186
Run-TryBot: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.