Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: builtin should be ranked higher in search #40622

Open
komuw opened this issue Aug 6, 2020 · 3 comments
Open

x/pkgsite: builtin should be ranked higher in search #40622

komuw opened this issue Aug 6, 2020 · 3 comments

Comments

@komuw
Copy link
Contributor

@komuw komuw commented Aug 6, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/search?q=builtin

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.59 Safari/537.36

screenshot

Screenshot 2020-08-06 at 20 04 37

What did you do?

Visited the page.

What did you expect to see?

The stdlib builtin package listed as the first result; https://pkg.go.dev/builtin/?tab=doc

What did you see instead?

A list of packages, with the stdlib one not been one of them

@gopherbot gopherbot added this to the Unreleased milestone Aug 6, 2020
@mvdan
Copy link
Member

@mvdan mvdan commented Aug 6, 2020

Perhaps this is because builtin is not a normal package, it's not a package you can import. So if they have any "sort by" parameters like "number of packages that import this package", then that should always be 0 for builtin.

@mvdan
Copy link
Member

@mvdan mvdan commented Aug 6, 2020

(To clarify, I agree this is likely a bug; I'm just guessing what the cause might be)

@toothrot toothrot added the pkgsite label Aug 7, 2020
@toothrot
Copy link
Contributor

@toothrot toothrot commented Aug 7, 2020

@julieqiu julieqiu changed the title x/pkgsite: give more weight to stdlib x/pkgsite: builtin should be ranked higher in search Aug 13, 2020
@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/search Aug 19, 2020
@gopherbot gopherbot added the go.dev label Sep 18, 2020
@julieqiu julieqiu removed the go.dev label Sep 19, 2020
@gopherbot gopherbot added the go.dev label Sep 19, 2020
@julieqiu julieqiu removed the go.dev label Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.