Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: builtin should be ranked higher in search #40622

Closed
komuw opened this issue Aug 6, 2020 · 5 comments
Closed

x/pkgsite: builtin should be ranked higher in search #40622

komuw opened this issue Aug 6, 2020 · 5 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/search Issues related to pkg.go.dev search functionality pkgsite
Milestone
pkgsite/search

Comments

@komuw
Copy link
Contributor

komuw commented Aug 6, 2020 •
edited
Loading

What is the URL of the page with the issue?

https://pkg.go.dev/search?q=builtin

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.59 Safari/537.36

screenshot

Screenshot 2020-08-06 at 20 04 37

What did you do?

Visited the page.

What did you expect to see?

The stdlib builtin package listed as the first result; https://pkg.go.dev/builtin/?tab=doc

What did you see instead?

A list of packages, with the stdlib one not been one of them
@gopherbot gopherbot added this to the Unreleased milestone Aug 6, 2020
@mvdan
Copy link
Member

mvdan commented Aug 6, 2020

Perhaps this is because builtin is not a normal package, it's not a package you can import. So if they have any "sort by" parameters like "number of packages that import this package", then that should always be 0 for builtin.

@mvdan
Copy link
Member

mvdan commented Aug 6, 2020

(To clarify, I agree this is likely a bug; I'm just guessing what the cause might be)

@toothrot
Copy link
Contributor

toothrot commented Aug 7, 2020

/cc @julieqiu @jba @jamalc

@julieqiu julieqiu added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 7, 2020
@julieqiu julieqiu changed the title x/pkgsite: give more weight to stdlib x/pkgsite: builtin should be ranked higher in search Aug 13, 2020
@julieqiu julieqiu mentioned this issue Aug 13, 2020
Closed
@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/search Aug 19, 2020
@jzacsh jzacsh mentioned this issue Sep 13, 2020
Closed
@julieqiu julieqiu removed the website label Sep 19, 2020
@julieqiu julieqiu removed the website label Sep 19, 2020
@hyangah hyangah added the pkgsite/search Issues related to pkg.go.dev search functionality label May 20, 2022
@Deleplace
Copy link
Contributor

I had the same experience today, IMO we may indeed regard this as a bug.

@komuw komuw mentioned this issue Nov 23, 2023
Open
@gabyhelp gabyhelp mentioned this issue Aug 7, 2024
Closed
@seankhliao
Copy link
Member

Duplicate of #41369

@seankhliao seankhliao marked this as a duplicate of #41369 Dec 29, 2024
@seankhliao seankhliao closed this as not planned Won't fix, can't repro, duplicate, stale Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/search Issues related to pkg.go.dev search functionality pkgsite
Projects
None yet
Milestone
pkgsite/search
Development

No branches or pull requests
8 participants
@toothrot @mvdan @hyangah @komuw @julieqiu @gopherbot @seankhliao @Deleplace