Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: hang saving files / 100% CPU on master/90696ccd #40626

Closed
bmhatfield opened this issue Aug 6, 2020 · 2 comments
Closed

x/tools/gopls: hang saving files / 100% CPU on master/90696ccd #40626

bmhatfield opened this issue Aug 6, 2020 · 2 comments
Labels
Milestone

Comments

@bmhatfield
Copy link

@bmhatfield bmhatfield commented Aug 6, 2020

What version of Go are you using (go version)?

go version go1.14.6 darwin/amd64

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

OSX/x86_64

What did you do?

I keep my local gopls regularly updated from master. Sometime in the past 24h, a commit was introduced that has caused significant performance / hanging issues with gopls for me locally. Nothing is logged when this happens.

Commits Tried:

90696ccd - hanging/100% CPU
b4d825fe - hanging/100% CPU
d55f2edd - hanging/100% CPU

fec4f28e - working normally

What did you expect to see?

Normal gopls functionality.

What did you see instead?

100% CPU in activity monitor, VSCode not performing autocompletes/cannot code navigate/cannot save files due to waiting for code actions.

@gopherbot gopherbot added this to the Unreleased milestone Aug 6, 2020
@bmhatfield
Copy link
Author

@bmhatfield bmhatfield commented Aug 6, 2020

This may have been fixed in: golang/tools@ee49e49 - I am running from 9099c90c and it seems to be working again.

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Aug 6, 2020

Yep, that should be it. Sorry that you picked up that bug.

@stamblerre stamblerre closed this Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.