Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website/internal/dl: include docs on how to init datastore or memcache dependencies #40630

Open
kevinburke1 opened this issue Aug 7, 2020 · 4 comments

Comments

@kevinburke1
Copy link

@kevinburke1 kevinburke1 commented Aug 7, 2020

I am trying to make changes to the /dl page, but this page requires the ability to pull data from a memcache or Cloud datastore in order to render the page contents, and it does not look like there is documentation on how to put the necessary data in the Cloud datastore.

@toothrot
Copy link
Contributor

@toothrot toothrot commented Aug 7, 2020

/cc @dmitshur

Loading

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Aug 7, 2020

Unrelated to documentation, please be sure to discuss changes to the /dl page in an issue first.

Loading

@kevinburke
Copy link
Contributor

@kevinburke kevinburke commented Sep 10, 2020

My idea was to try to fall back to loading the release history from internal/history if the datastore is not initialized, but everything seems too tightly coupled to google cloud to make that work.

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 13, 2020

Change https://golang.org/cl/254538 mentions this issue: internal/dl: add release dates to dl page

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants