Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: use progress notifications for the initial workspace load #40632

Closed
axetroy opened this issue Aug 7, 2020 · 1 comment
Closed

x/tools/gopls: use progress notifications for the initial workspace load #40632

axetroy opened this issue Aug 7, 2020 · 1 comment
Assignees
Labels
Milestone

Comments

@axetroy
Copy link

@axetroy axetroy commented Aug 7, 2020

Is your feature request related to a problem? Please describe.

vscode-go initialization takes a while. During this time, there is no grammar prompt and nothing is ready.

I don’t know when it will be ready, it may depend on the size of the project

If it shows a loading state, this can alleviate user anxiety. At least let me know that it is working

Describe the solution you'd like

like Typescript extension does

Describe alternatives you've considered

None

Additional context

None

@axetroy axetroy changed the title Show loading in statusbar before LSP not ready like Typescript does Show loading in statusbar before LSP is ready like Typescript does Aug 7, 2020
@stamblerre stamblerre transferred this issue from golang/vscode-go Aug 7, 2020
@stamblerre stamblerre changed the title Show loading in statusbar before LSP is ready like Typescript does x/tools/gopls: use progress notifications for the initial workspace load Aug 7, 2020
@gopherbot gopherbot added this to the Unreleased milestone Aug 7, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v1.0.0 Aug 7, 2020
@dandua98 dandua98 self-assigned this Aug 10, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 14, 2020

Change https://golang.org/cl/248623 mentions this issue: internal/lsp: adds initial workspace load notification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.