Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: handle transferred issues #40640

Open
toothrot opened this issue Aug 7, 2020 · 4 comments
Open

x/build/cmd/gopherbot: handle transferred issues #40640

toothrot opened this issue Aug 7, 2020 · 4 comments

Comments

@toothrot
Copy link
Contributor

@toothrot toothrot commented Aug 7, 2020

Gopherbot currently gets stuck in an error loop when it encounters an issue that has been transferred, such as golang/vscode-go#298, which is now #40101.

2020/08/07 19:14:35 close stale WaitingForInfo: GET https://api.github.com/repos/golang/vscode-go/issues/298/comments?per_page=1000&since=2020-07-07T17%3A07%3A54Z: 404 Not Found []
2020/08/07 19:14:35 gopherbot ran in 3.547726498s
2020/08/07 19:14:35 sleeping 30s after previous error.

It shouldn't get stuck when this happens.

/cc @golang/osp-team

@toothrot toothrot added this to the Unreleased milestone Aug 7, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 7, 2020

Change https://golang.org/cl/247409 mentions this issue: cmd/gopherbot: skip commenting on nonexistent issues

gopherbot pushed a commit to golang/build that referenced this issue Aug 7, 2020
When an issue is transferred, we incorrectly continue trying to manage
the issue with Gopherbot, even though we should be able to pick up the
new issue. As a temporary fix, this change skips issues which return a
404 when trying to comment.

For golang/go#40640

Change-Id: I9280fab7a8ec4ead0d3e1cc5695d9b7eb39d6b32
Reviewed-on: https://go-review.googlesource.com/c/build/+/247409
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Sep 18, 2020

Change https://golang.org/cl/256040 mentions this issue: cmd/gopherbot: skip labeling nonexistent issues

gopherbot pushed a commit to golang/build that referenced this issue Sep 18, 2020
When an issue is transferred, we incorrectly continue trying to manage
the issue with Gopherbot, even though we should be able to pick up the
new issue and decide if it is Gopherbot's responsibility. As a temporary
fix, this change skips issues which return a 404 when adding labels.

For golang/go#40640

Change-Id: Ib84490c1e41a71b14c0f736a41d1f6032a3c2c92
Reviewed-on: https://go-review.googlesource.com/c/build/+/256040
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Apr 9, 2021

This issue also affected a recently added "set vscode-go milestones" task. There is more information available in #45461.

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 9, 2021

Change https://golang.org/cl/309069 mentions this issue: cmd/gopherbot: only milestone new vscode-go issues as Untriaged

gopherbot pushed a commit to golang/build that referenced this issue Apr 9, 2021
Transferred issues are getting categorized as part of this set and
returning errors when the milestone is applied, causing GitHub to rate
limit Gopherbot. Only try to milestone newly created issues as a result.

And re-enable that task now that the number of transferred issues should
be lower.

For golang/go#40640

Change-Id: I7e772d1bcda46e982f0f375481108ff10c064ae9
Reviewed-on: https://go-review.googlesource.com/c/build/+/309069
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants