Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/goversion: increment Version at start of cycle #40705

Open
dmitshur opened this issue Aug 11, 2020 · 24 comments
Open

internal/goversion: increment Version at start of cycle #40705

dmitshur opened this issue Aug 11, 2020 · 24 comments
Labels
early-in-cycle A change that should be done early in the 3 month dev cycle. NeedsFix The path to resolution is known, but the work has not been done. recurring Issues that should never be closed, but moved to the next milestone once fixed in the current one. release-blocker
Milestone

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Aug 11, 2020

goversion.Version needs to be incremented by one at the start of each development cycle, to match the upcoming major Go release version.

Once done, this issue should be moved to the next major release milestone.

(CC @golang/release.)

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. early-in-cycle A change that should be done early in the 3 month dev cycle. release-blocker recurring Issues that should never be closed, but moved to the next milestone once fixed in the current one. labels Aug 11, 2020
@dmitshur dmitshur self-assigned this Aug 11, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/248038 mentions this issue: internal/goversion: update Version to 1.16

@dmitshur dmitshur changed the title internal/goversion: increment Version internal/goversion: increment Version at start of cycle Aug 11, 2020
@dmitshur dmitshur removed their assignment Aug 11, 2020
gopherbot pushed a commit that referenced this issue Aug 12, 2020
This is the start of the Go 1.16 development cycle, so update the
Version value accordingly. It represents the Go 1.x version that
will soon open up for development (and eventually become released).

Historically, we used to bump this at an arbitrary time throughout
the development cycle, but it's better to be more predictable about
updating it. The start of a development cycle should be the most
appropriate time: it clearly marks the boundary between 1.15 and
1.16 development, and doing it early can help catch issues in other
tooling. See issue #38704 for more background.

There is no longer a need to update the list of Go versions in
src/go/build/doc.go because it does not exist as of CL 232981.

For #40705.
Updates #38704.
Updates #37018.

Change-Id: Id8ee733b5e79c53b6cd03509c6560614d8743833
Reviewed-on: https://go-review.googlesource.com/c/go/+/248038
Reviewed-by: Carlos Amedee <carlos@golang.org>
@dmitshur dmitshur added this to the Go1.16 milestone Aug 12, 2020
@dmitshur
Copy link
Contributor Author

CL 248038 took care of this for the Go 1.16 cycle, so moving this issue to be looked at at the start of the Go 1.17 cycle.

@dmitshur dmitshur modified the milestones: Go1.16, Go1.17 Aug 12, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/275297 mentions this issue: internal/goversion: update Version to 1.17

@bcmills
Copy link
Contributor

bcmills commented Feb 16, 2021

CL 275297 merged for Go 1.17. Moving to 1.18.

gopherbot pushed a commit that referenced this issue Feb 16, 2021
(The corresponding update for the last release cycle was CL 248038.)

For #40705.

Change-Id: I13becdc4c3718a1c6986876ec56879cce3bcb34f
Reviewed-on: https://go-review.googlesource.com/c/go/+/275297
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@bcmills bcmills modified the milestones: Go1.17, Go1.18 Feb 16, 2021
@cagedmantis cagedmantis self-assigned this Aug 11, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/341590 mentions this issue: internal/goversion: update Version to 1.18

gopherbot pushed a commit that referenced this issue Aug 12, 2021
This is the start of the Go 1.18 development cycle, so update the
Version value accordingly. It represents the Go 1.x version that
will soon open up for development (and eventually become released).

Updates #40705
Updates #47351

Change-Id: Icfb99e28529a3c9fb7394e114a34586f613dfcbf
Reviewed-on: https://go-review.googlesource.com/c/go/+/341590
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@cagedmantis
Copy link
Contributor

CL 341590 has been merged for Go 1.18. Moving this to the 1.19 milestone.

@cagedmantis cagedmantis modified the milestones: Go1.18, Go1.19 Aug 12, 2021
@cagedmantis cagedmantis removed their assignment Aug 12, 2021
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/388376 mentions this issue: internal/goversion: update Version to 1.19

gopherbot pushed a commit that referenced this issue Jul 18, 2023
For #40705.

Change-Id: I06df5f4ea5cf65420c2dac754a1e65ac819c1090
Reviewed-on: https://go-review.googlesource.com/c/go/+/510735
Auto-Submit: Heschi Kreinick <heschi@google.com>
Reviewed-by: Eli Bendersky <eliben@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Heschi Kreinick <heschi@google.com>
@gopherbot
Copy link
Contributor

This issue is currently labeled as early-in-cycle for Go 1.22.
That time is now, so a friendly reminder to look at it again.

@dmitshur
Copy link
Contributor Author

CL 510735 took care of this for 1.22. Moving to 1.23.

@dmitshur dmitshur modified the milestones: Go1.22, Go1.23 Jul 20, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/557155 mentions this issue: internal/goversion: update Version to 1.23

@cagedmantis cagedmantis self-assigned this Jan 19, 2024
gopherbot pushed a commit that referenced this issue Jan 19, 2024
(The corresponding update for the last release cycle was CL 510735.)

For #40705
For #64340

Change-Id: I123ce68131a6c7b0344cab54cd29402cabb57225
Reviewed-on: https://go-review.googlesource.com/c/go/+/557155
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@gopherbot
Copy link
Contributor

This issue is currently labeled as early-in-cycle for Go 1.23.
That time is now, so a friendly reminder to look at it again.

@dmitshur
Copy link
Contributor Author

CL 557155 took care of this for 1.23. Moving to 1.24.

@dmitshur dmitshur modified the milestones: Go1.23, Go1.24 Jan 22, 2024
ezz-no pushed a commit to ezz-no/go-ezzno that referenced this issue Feb 18, 2024
(The corresponding update for the last release cycle was CL 510735.)

For golang#40705
For golang#64340

Change-Id: I123ce68131a6c7b0344cab54cd29402cabb57225
Reviewed-on: https://go-review.googlesource.com/c/go/+/557155
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@dmitshur dmitshur self-assigned this Jul 22, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/600176 mentions this issue: internal/goversion: update Version to 1.24

gopherbot pushed a commit that referenced this issue Jul 22, 2024
Go 1.24 is in the process of being opened for development (to be
eventually released). This change marks the very beginning of its
development cycle, updating the Version value accordingly.

For #40705.
For #67586.

Change-Id: Ibd194f229e7dbd25bc2713f86330fab50ea1dfaa
Reviewed-on: https://go-review.googlesource.com/c/go/+/600176
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
@dmitshur
Copy link
Contributor Author

CL 600176 did this for Go 1.24; moving to the next milestone.

@dmitshur dmitshur modified the milestones: Go1.24, Go1.25 Jul 22, 2024
@dmitshur dmitshur removed their assignment Jul 22, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/646155 mentions this issue: internal/goversion: update Version to 1.25

gopherbot pushed a commit that referenced this issue Feb 3, 2025
Go 1.25 is in the process of being opened for development (to be
eventually released). This change marks the very beginning of its
development cycle, updating the Version value accordingly.

For #40705.
For #70525.

Change-Id: If673d4aeddc376fefe6bddc3ec2704ca91245777
Reviewed-on: https://go-review.googlesource.com/c/go/+/646155
Reviewed-by: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@gopherbot
Copy link
Contributor

This issue is currently labeled as early-in-cycle for Go 1.25.
That time is now, so a friendly reminder to look at it again.

@cherrymui
Copy link
Member

cherrymui commented Feb 3, 2025

CL 646155 did this for Go 1.25. Bump to the next cycle.

@cherrymui cherrymui modified the milestones: Go1.25, Go1.26 Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
early-in-cycle A change that should be done early in the 3 month dev cycle. NeedsFix The path to resolution is known, but the work has not been done. recurring Issues that should never be closed, but moved to the next milestone once fixed in the current one. release-blocker
Projects
Status: No status
Development

No branches or pull requests

5 participants