Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/goversion: increment Version at start of cycle #40705

Open
dmitshur opened this issue Aug 11, 2020 · 13 comments
Open

internal/goversion: increment Version at start of cycle #40705

dmitshur opened this issue Aug 11, 2020 · 13 comments
Labels
early-in-cycle A change that should be done early in the 3 month dev cycle. NeedsFix The path to resolution is known, but the work has not been done. recurring Issues that should never be closed, but moved to the next milestone once fixed in the current one. release-blocker
Milestone
Go1.22

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Aug 11, 2020 •
edited

goversion.Version needs to be incremented by one at the start of each development cycle, to match the upcoming major Go release version.

Once done, this issue should be moved to the next major release milestone.

(CC @golang/release.)
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. early-in-cycle A change that should be done early in the 3 month dev cycle. release-blocker recurring Issues that should never be closed, but moved to the next milestone once fixed in the current one. labels Aug 11, 2020
@dmitshur dmitshur self-assigned this Aug 11, 2020
@dmitshur dmitshur mentioned this issue Aug 11, 2020
Closed
@gopherbot
Copy link

Change https://golang.org/cl/248038 mentions this issue: internal/goversion: update Version to 1.16

@dmitshur dmitshur changed the title internal/goversion: increment Version internal/goversion: increment Version at start of cycle Aug 11, 2020
@dmitshur dmitshur removed their assignment Aug 11, 2020
gopherbot pushed a commit that referenced this issue Aug 12, 2020
@dmitshur
internal/goversion: update Version to 1.16
813b6bb 
This is the start of the Go 1.16 development cycle, so update the
Version value accordingly. It represents the Go 1.x version that
will soon open up for development (and eventually become released).

Historically, we used to bump this at an arbitrary time throughout
the development cycle, but it's better to be more predictable about
updating it. The start of a development cycle should be the most
appropriate time: it clearly marks the boundary between 1.15 and
1.16 development, and doing it early can help catch issues in other
tooling. See issue #38704 for more background.

There is no longer a need to update the list of Go versions in
src/go/build/doc.go because it does not exist as of CL 232981.

For #40705.
Updates #38704.
Updates #37018.

Change-Id: Id8ee733b5e79c53b6cd03509c6560614d8743833
Reviewed-on: https://go-review.googlesource.com/c/go/+/248038
Reviewed-by: Carlos Amedee <carlos@golang.org>
@dmitshur dmitshur added this to the Go1.16 milestone Aug 12, 2020
@dmitshur
Copy link
Contributor Author

CL 248038 took care of this for the Go 1.16 cycle, so moving this issue to be looked at at the start of the Go 1.17 cycle.

@dmitshur dmitshur modified the milestones: Go1.16, Go1.17 Aug 12, 2020
@gopherbot
Copy link

Change https://golang.org/cl/275297 mentions this issue: internal/goversion: update Version to 1.17

@bcmills
Copy link
Member

bcmills commented Feb 16, 2021

CL 275297 merged for Go 1.17. Moving to 1.18.

gopherbot pushed a commit that referenced this issue Feb 16, 2021
@bcmills
internal/goversion: update Version to 1.17
5faf941 
(The corresponding update for the last release cycle was CL 248038.)

For #40705.

Change-Id: I13becdc4c3718a1c6986876ec56879cce3bcb34f
Reviewed-on: https://go-review.googlesource.com/c/go/+/275297
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@bcmills bcmills modified the milestones: Go1.17, Go1.18 Feb 16, 2021
@dmitshur dmitshur mentioned this issue Feb 18, 2021
Closed
@cagedmantis cagedmantis self-assigned this Aug 11, 2021
@gopherbot
Copy link

Change https://golang.org/cl/341590 mentions this issue: internal/goversion: update Version to 1.18

gopherbot pushed a commit that referenced this issue Aug 12, 2021
@cagedmantis
internal/goversion: update Version to 1.18
46fd547 
This is the start of the Go 1.18 development cycle, so update the
Version value accordingly. It represents the Go 1.x version that
will soon open up for development (and eventually become released).

Updates #40705
Updates #47351

Change-Id: Icfb99e28529a3c9fb7394e114a34586f613dfcbf
Reviewed-on: https://go-review.googlesource.com/c/go/+/341590
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@cagedmantis
Copy link
Contributor

CL 341590 has been merged for Go 1.18. Moving this to the 1.19 milestone.

@cagedmantis cagedmantis modified the milestones: Go1.18, Go1.19 Aug 12, 2021
@cagedmantis cagedmantis removed their assignment Aug 12, 2021
@cagedmantis cagedmantis added this to Done in Go Release Team Aug 12, 2021
@dmitshur dmitshur mentioned this issue Feb 28, 2022
Closed
3 tasks
@gopherbot
Copy link

Change https://go.dev/cl/388376 mentions this issue: internal/goversion: update Version to 1.19

gopherbot pushed a commit that referenced this issue Feb 28, 2022
@cagedmantis
internal/goversion: update Version to 1.19
936c7fb 
This is the start of the Go 1.19 development cycle, so update the
Version value accordingly. It represents the Go 1.x version that will
soon open up for development (and eventually become released).

Updates #40705
Updates #51336

Change-Id: Ic4b3f2c04b1fa5c588cb6d62e829f2ed1864e511
Reviewed-on: https://go-review.googlesource.com/c/go/+/388376
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Trust: Alex Rakoczy <alex@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Alex Rakoczy <alex@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
@cagedmantis
Copy link
Contributor

CL 388376 has been merged for Go 1.19. Moving this to the 1.20 milestone.

@gopherbot
Copy link

This issue is currently labeled as early-in-cycle for Go 1.19.
That time is now, so a friendly reminder to look at it again.

@dmitshur dmitshur modified the milestones: Go1.19, Go1.20 Mar 16, 2022
@dmitshur dmitshur removed this from Done in Go Release Team Mar 16, 2022
@joedian joedian mentioned this issue Jul 12, 2022
Closed
8 tasks
@gopherbot
Copy link

Change https://go.dev/cl/420816 mentions this issue: internal/goversion: update Version to 1.20

@dmitshur dmitshur self-assigned this Aug 2, 2022
gopherbot pushed a commit that referenced this issue Aug 2, 2022
@dmitshur @gopherbot
internal/goversion: update Version to 1.20
d723df7 
This is the start of the Go 1.20 development cycle, so update the
Version value accordingly. It represents the Go 1.x version that
will soon open up for development (and eventually become released).

For #40705.
For #53812.

Change-Id: Ic8919a61c9b2f3139717434b9c776d1597175448
Reviewed-on: https://go-review.googlesource.com/c/go/+/420816
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@dmitshur
Copy link
Contributor Author

dmitshur commented Aug 2, 2022

CL 420816 took care of this for the start of the 1.20 cycle. Moving this to the next.

@dmitshur dmitshur modified the milestones: Go1.20, Go1.21 Aug 2, 2022
@dmitshur dmitshur removed their assignment Aug 2, 2022
jproberts pushed a commit to jproberts/go that referenced this issue Aug 10, 2022
@dmitshur @jproberts
internal/goversion: update Version to 1.20
c21fb31 
This is the start of the Go 1.20 development cycle, so update the
Version value accordingly. It represents the Go 1.x version that
will soon open up for development (and eventually become released).

For golang#40705.
For golang#53812.

Change-Id: Ic8919a61c9b2f3139717434b9c776d1597175448
Reviewed-on: https://go-review.googlesource.com/c/go/+/420816
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@cagedmantis cagedmantis mentioned this issue Jan 11, 2023
Closed
5 tasks
@gopherbot
Copy link

Change https://go.dev/cl/462456 mentions this issue: internal/goversion: update Version to 1.21

gopherbot pushed a commit that referenced this issue Jan 17, 2023
@cherrymui
internal/goversion: update Version to 1.21
83f8688 
This is the start of the Go 1.21 development cycle, so update the
Version value accordingly. It represents the Go 1.x version that
will soon open up for development (and eventually become released).

For #40705.
For #57736.

Change-Id: I31b739f632bdc8d14f46560e0e5bf333fb8e7740
Reviewed-on: https://go-review.googlesource.com/c/go/+/462456
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cherry Mui <cherryyz@google.com>
@cherrymui
Copy link
Member

CL submitted for Go 1.21. Move to 1.22.

@cherrymui cherrymui modified the milestones: Go1.21, Go1.22 Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
early-in-cycle A change that should be done early in the 3 month dev cycle. NeedsFix The path to resolution is known, but the work has not been done. recurring Issues that should never be closed, but moved to the next milestone once fixed in the current one. release-blocker
Projects
Release Status & Blockers (1.20)
Status: No status
Milestone
Go1.22
Development

No branches or pull requests
5 participants
@cagedmantis @dmitshur @bcmills @gopherbot @cherrymui