Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/goversion: increment Version at start of cycle #40705

Open
dmitshur opened this issue Aug 11, 2020 · 9 comments
Open

internal/goversion: increment Version at start of cycle #40705

dmitshur opened this issue Aug 11, 2020 · 9 comments
Labels
early-in-cycle NeedsFix recurring release-blocker
Milestone

Comments

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Aug 11, 2020

goversion.Version needs to be incremented by one at the start of each development cycle, to match the upcoming major Go release version.

Once done, this issue should be moved to the next major release milestone.

/cc @cagedmantis @toothrot @andybons @heschik @bcmills

@dmitshur dmitshur added NeedsFix early-in-cycle release-blocker recurring labels Aug 11, 2020
@dmitshur dmitshur self-assigned this Aug 11, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 11, 2020

Change https://golang.org/cl/248038 mentions this issue: internal/goversion: update Version to 1.16

@dmitshur dmitshur changed the title internal/goversion: increment Version internal/goversion: increment Version at start of cycle Aug 11, 2020
@dmitshur dmitshur removed their assignment Aug 11, 2020
gopherbot pushed a commit that referenced this issue Aug 12, 2020
This is the start of the Go 1.16 development cycle, so update the
Version value accordingly. It represents the Go 1.x version that
will soon open up for development (and eventually become released).

Historically, we used to bump this at an arbitrary time throughout
the development cycle, but it's better to be more predictable about
updating it. The start of a development cycle should be the most
appropriate time: it clearly marks the boundary between 1.15 and
1.16 development, and doing it early can help catch issues in other
tooling. See issue #38704 for more background.

There is no longer a need to update the list of Go versions in
src/go/build/doc.go because it does not exist as of CL 232981.

For #40705.
Updates #38704.
Updates #37018.

Change-Id: Id8ee733b5e79c53b6cd03509c6560614d8743833
Reviewed-on: https://go-review.googlesource.com/c/go/+/248038
Reviewed-by: Carlos Amedee <carlos@golang.org>
@dmitshur dmitshur added this to the Go1.16 milestone Aug 12, 2020
@dmitshur
Copy link
Contributor Author

@dmitshur dmitshur commented Aug 12, 2020

CL 248038 took care of this for the Go 1.16 cycle, so moving this issue to be looked at at the start of the Go 1.17 cycle.

@dmitshur dmitshur removed this from the Go1.16 milestone Aug 12, 2020
@dmitshur dmitshur added this to the Go1.17 milestone Aug 12, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 3, 2020

Change https://golang.org/cl/275297 mentions this issue: internal/goversion: update Version to 1.17

@bcmills
Copy link
Member

@bcmills bcmills commented Feb 16, 2021

CL 275297 merged for Go 1.17. Moving to 1.18.

gopherbot pushed a commit that referenced this issue Feb 16, 2021
(The corresponding update for the last release cycle was CL 248038.)

For #40705.

Change-Id: I13becdc4c3718a1c6986876ec56879cce3bcb34f
Reviewed-on: https://go-review.googlesource.com/c/go/+/275297
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@bcmills bcmills removed this from the Go1.17 milestone Feb 16, 2021
@bcmills bcmills added this to the Go1.18 milestone Feb 16, 2021
@cagedmantis cagedmantis self-assigned this Aug 11, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 11, 2021

Change https://golang.org/cl/341590 mentions this issue: internal/goversion: update Version to 1.18

gopherbot pushed a commit that referenced this issue Aug 12, 2021
This is the start of the Go 1.18 development cycle, so update the
Version value accordingly. It represents the Go 1.x version that
will soon open up for development (and eventually become released).

Updates #40705
Updates #47351

Change-Id: Icfb99e28529a3c9fb7394e114a34586f613dfcbf
Reviewed-on: https://go-review.googlesource.com/c/go/+/341590
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Aug 12, 2021

CL 341590 has been merged for Go 1.18. Moving this to the 1.19 milestone.

@cagedmantis cagedmantis removed this from the Go1.18 milestone Aug 12, 2021
@cagedmantis cagedmantis added this to the Go1.19 milestone Aug 12, 2021
@cagedmantis cagedmantis removed their assignment Aug 12, 2021
@cagedmantis cagedmantis added this to Done in Go Release Team Aug 12, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Feb 28, 2022

Change https://go.dev/cl/388376 mentions this issue: internal/goversion: update Version to 1.19

gopherbot pushed a commit that referenced this issue Feb 28, 2022
This is the start of the Go 1.19 development cycle, so update the
Version value accordingly. It represents the Go 1.x version that will
soon open up for development (and eventually become released).

Updates #40705
Updates #51336

Change-Id: Ic4b3f2c04b1fa5c588cb6d62e829f2ed1864e511
Reviewed-on: https://go-review.googlesource.com/c/go/+/388376
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Trust: Alex Rakoczy <alex@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Alex Rakoczy <alex@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Feb 28, 2022

CL 388376 has been merged for Go 1.19. Moving this to the 1.20 milestone.

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 16, 2022

This issue is currently labeled as early-in-cycle for Go 1.19.
That time is now, so a friendly reminder to look at it again.

@dmitshur dmitshur removed this from the Go1.19 milestone Mar 16, 2022
@dmitshur dmitshur added this to the Go1.20 milestone Mar 16, 2022
@dmitshur dmitshur removed this from Done in Go Release Team Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
early-in-cycle NeedsFix recurring release-blocker
Projects
None yet
Development

No branches or pull requests

4 participants