Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: Doesn't auto-complete package statements for new files #40713

Closed
segevfiner opened this issue Aug 12, 2020 · 1 comment
Closed

x/tools/gopls: Doesn't auto-complete package statements for new files #40713

segevfiner opened this issue Aug 12, 2020 · 1 comment
Labels
Milestone

Comments

@segevfiner
Copy link
Contributor

@segevfiner segevfiner commented Aug 12, 2020

What version of Go are you using (go version)?

$ go version
go version go1.14.7 darwin/amd64
# gopls version
golang.org/x/tools/gopls 0.4.4
    golang.org/x/tools/gopls@v0.4.4 h1:8djGYsaZ0ByP0vaXg4T+mnyfDcHpWKSZ+tpQSGv9ahk=

VS Code version v1.47.3
vscode-go v0.16.1

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/segev/Library/Caches/go-build"
GOENV="/Users/segev/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/segev/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.14.7/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.14.7/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/b_/c6yh0ksn63d1yy192x2p9f4c0000gn/T/go-build425202633=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

  1. Add a new file to a package that already has files. (Using Go modules)
  2. Try to auto-complete pack or some similar prefix at the start of the file.
  3. You get no completions.

(Using gopls with vscode-go)

What did you expect to see?

I expect to see a complete for a package statement with the name of the package, saving me the need to type it out.

What did you see instead?

I get no such completion.

I would also expect it to provide package statement completion for the first file in a new package, guessing what should be the package name based on the import path.

@gopherbot gopherbot added this to the Unreleased milestone Aug 12, 2020
@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Aug 12, 2020

Duplicate of #34008

@stamblerre stamblerre marked this as a duplicate of #34008 Aug 12, 2020
@stamblerre stamblerre closed this Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.