Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go 1.15 release note fix #40716

Closed
ostcar opened this issue Aug 12, 2020 · 4 comments
Closed

go 1.15 release note fix #40716

ostcar opened this issue Aug 12, 2020 · 4 comments

Comments

@ostcar
Copy link

@ostcar ostcar commented Aug 12, 2020

As descried here, there is a backwards incompatible change between go 1.14 and go 1.15. It was a bug in go 1.14 and therefore is not guarded by the golang 1 promise.

I think, there should be a note in the go 1.15 release notes about this backwards incompatible change.

@mvdan
Copy link
Member

@mvdan mvdan commented Aug 12, 2020

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Aug 12, 2020

As descried here,

@ostcar Can you please answer these questions from the issue template:

  1. What version of Go are you using (go version)? (Go 1.15, I understand.)
  2. What operating system and processor architecture are you using (go env)?
  3. What did you do?
  4. What did you expect to see?
  5. What did you see instead?

Without complete information, it's hard to understand where the problem is. Thank you.

See CONTRIBUTING.md#filing-issues for more information.

@ostcar
Copy link
Author

@ostcar ostcar commented Aug 12, 2020

I am really sorry. When I was filling out the template and build an example program, I released, that there was a concurrency bug in my code. The behavior with go 1.14 and go 1.15 are the same. Only the goroutines run in a different order.

I thought, the issue template was not necessary, since it was only an issue with release notes. But this showed me, that it is always important to fill out the template. I promise to do better the next time. Sorry for all the noise. And thank you for your great work!

@ostcar ostcar closed this Aug 12, 2020
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Aug 12, 2020

No worries, thanks for getting to the bottom of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.