Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: correctly observe the -remote flags for commands other than serve #40732

findleyr opened this issue Aug 12, 2020 · 1 comment


Copy link

@findleyr findleyr commented Aug 12, 2020

Currently, the handling for -remote is happening within the LSP forwarder itself, meaning it only works for the gopls serve command.

This was an oversight. This functionality should work identically for all commands.

@findleyr findleyr self-assigned this Aug 12, 2020
@gopherbot gopherbot added this to the Unreleased milestone Aug 12, 2020
Copy link

@gopherbot gopherbot commented Aug 12, 2020

Change mentions this issue: internal/lsp/cmd: make -remote consistent across commands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants