Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: is the initial parenthesis really necessary for left hand side menu? #40744

Closed
pjebs opened this issue Aug 13, 2020 · 7 comments
Closed

Comments

@pjebs
Copy link
Contributor

@pjebs pjebs commented Aug 13, 2020

image

(o) XXXXX()

@andybons
Copy link
Member

@andybons andybons commented Aug 13, 2020

It’s important to be able to discern between a method and a function that returns that type.

https://pkg.go.dev/time?tab=doc#Date shows an example of this.

Is there an alternative you suggest?

@andybons andybons modified the milestones: Unplanned, Unreleased Aug 13, 2020
@andybons andybons changed the title pkg.go.dev: Is the initial parenthesis really necessary for left hand side menu? x/pkgsite: Is the initial parenthesis really necessary for left hand side menu? Aug 13, 2020
@andybons andybons changed the title x/pkgsite: Is the initial parenthesis really necessary for left hand side menu? x/pkgsite: os the initial parenthesis really necessary for left hand side menu? Aug 13, 2020
@andybons andybons changed the title x/pkgsite: os the initial parenthesis really necessary for left hand side menu? x/pkgsite: is the initial parenthesis really necessary for left hand side menu? Aug 13, 2020
@pjebs
Copy link
Contributor Author

@pjebs pjebs commented Aug 13, 2020

What about an asterisk or italicized lower case c for constructors and nothing for everything else

@pjebs
Copy link
Contributor Author

@pjebs pjebs commented Aug 13, 2020

Also worth a note: there seems to be far fewer constructors than methods. Eg time.Time

@pjebs
Copy link
Contributor Author

@pjebs pjebs commented Aug 14, 2020

image

@andybons
Copy link
Member

@andybons andybons commented Aug 18, 2020

Duplicate of #40612

@andybons andybons marked this as a duplicate of #40612 Aug 18, 2020
@andybons andybons closed this Aug 18, 2020
@pjebs
Copy link
Contributor Author

@pjebs pjebs commented Aug 18, 2020

@andybons this issue is not even related to #40612 was it closed by mistake?

@andybons
Copy link
Member

@andybons andybons commented Aug 19, 2020

@pjebs it concerns the design of the left-hand nav and the presentation of its contents, so I merged it into that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants