Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: performance regression about 2~3ms since Go 1.15 on macOS, due to linking two more shared libraries [1.15 backport] #40764

Closed
gopherbot opened this issue Aug 13, 2020 · 6 comments
Labels
CherryPickCandidate FrozenDueToAge
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 13, 2020

@FiloSottile requested issue #40727 to be considered for backport to the next 1.15 minor release.

@gopherbot please open a backport issue for Go 1.15.

I am not sure this qualifies to be backported, but it might as it's a regression with no workaround.

The team will evaluate it in the backport issue.

@randall77
Copy link
Contributor

@randall77 randall77 commented Aug 13, 2020

I vote against backporting this. It's 3ms extra time on process startup, which doesn't seem serious enough to warrant a backport.

@itchyny
Copy link
Contributor

@itchyny itchyny commented Aug 14, 2020

The 3ms extra time seems to be based the original issue, so if you judge whether or not backport based on the overhead amount, would you benchmark and reevaluate the overhead please?

@networkimprov
Copy link

@networkimprov networkimprov commented Aug 17, 2020

Possibly related: #40781

@networkimprov
Copy link

@networkimprov networkimprov commented Aug 17, 2020

Backport posted:

Change https://golang.org/cl/248719 mentions this issue: [release-branch.go1.15] cmd/link: link dynamic library automatically

cc @cherrymui

@cherrymui
Copy link
Member

@cherrymui cherrymui commented Aug 18, 2020

I made a CL anyway, but feel free to reject (or accept).

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Aug 21, 2020

We have discussed this backport request in a release meeting, and decided this issue does not meet the bar for being backported to Go 1.15. The fix for this issue will be available in Go 1.16.

@dmitshur dmitshur removed this from the Go1.15.1 milestone Sep 1, 2020
@dmitshur dmitshur added this to the Go1.15.2 milestone Sep 1, 2020
@golang golang locked and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickCandidate FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

6 participants