Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: inline marker targets not reachable after assembly on ppc64x [1.14 backport] #40766

Closed
gopherbot opened this issue Aug 13, 2020 · 3 comments
Labels
CherryPickApproved FrozenDueToAge
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 13, 2020

@ianlancetaylor requested issue #40689 to be considered for backport to the next 1.14 minor release.

@gopherbot Please backport to 1.14 and 1.15

This bug can cause tracebacks to hang. There is no workaround.

@gopherbot gopherbot added the CherryPickCandidate label Aug 13, 2020
@gopherbot gopherbot added this to the Go1.14.8 milestone Aug 13, 2020
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Aug 13, 2020

Change https://golang.org/cl/248382 mentions this issue: cmd/internal/obj/ppc64: don't remove NOP in assembler

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Sep 2, 2020

Approving per discussion in a release meeting. This backport applies to both 1.15 (#40767) and 1.14 (this issue).

@dmitshur dmitshur added CherryPickApproved and removed CherryPickCandidate labels Sep 2, 2020
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Sep 3, 2020

Closed by merging 32dc9f7 to release-branch.go1.14.

gopherbot pushed a commit that referenced this issue Sep 3, 2020
…ssembler

Previously, the assembler removed NOPs from the Prog list in
obj9.go. NOPs shouldn't be removed if they were added as
an inline mark, as described in the issue below.

Fixes #40766

Once the NOPs were left in the Prog list, some instructions
were flagged as invalid because they had an operand which was
not represented in optab. In order to preserve the previous
assembler behavior, entries were added to optab for those
operand cases. They were not flagged as errors before because
the NOP instructions were removed before the code to check the
valid opcode/operand combinations.

Change-Id: Iae5145f94459027cf458e914d7c5d6089807ccf8
Reviewed-on: https://go-review.googlesource.com/c/go/+/247842
Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Paul Murphy <murp@ibm.com>
Reviewed-by: Michael Munday <mike.munday@ibm.com>
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit 7d7bd5a)
Reviewed-on: https://go-review.googlesource.com/c/go/+/248382
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
@golang golang locked and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickApproved FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

2 participants