Skip to content

cmd/compile: inline marker targets not reachable after assembly on arm  #40796

Closed

Description

@mundaym

The linux-arm buildbot is failing the test added in CL 247697. This is the same fundamental issue as seen in #40689 (ppc64x) and #40473 (s390x), and should be a similar fix.

The arm assembler is removing a Prog from the function while processing it. That same Prog is then being used to generate inlining data after assembly. Since the Prog was never assembled its PC is incorrect and so the generated inlining data is broken. This can cause problems with tracebacks, such as the infinite loop seen in #40473.

Build log: https://build.golang.org/log/eb1975072af9202c55e1ce8697f21fd94de691fe

Activity

  1. added
    arch-armIssues solely affecting the 32-bit arm architecture.
    on Aug 14, 2020
  2. added this to the Go1.16 milestone on Aug 14, 2020
  3. added
    NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.
    on Aug 14, 2020
  4. mundaym commented on Aug 14, 2020

    @mundaym
    MemberAuthor
  5. mundaym commented on Aug 14, 2020

    @mundaym
    MemberAuthor

    @gopherbot Please open backport issues.

    This bug can cause tracebacks to hang. There is no workaround. The fix for this issue will need to be backported before the test added in CL 247697 can be backported.

  6. gopherbot commented on Aug 14, 2020

    @gopherbot
    Contributor

    Backport issue(s) opened: #40797 (for 1.14), #40798 (for 1.15).

    Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

  7. gopherbot commented on Aug 15, 2020

    @gopherbot
    Contributor

    Change https://golang.org/cl/248684 mentions this issue: cmd/internal/obj: stop removing NOPs from instruction stream

  8. locked and limited conversation to collaborators on Aug 28, 2021
  9. added a commit that references this issue on Feb 17, 2026
    46ca7b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeNeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.arch-armIssues solely affecting the 32-bit arm architecture.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions