Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: inline marker targets not reachable after assembly on arm [1.14 backport] #40797

Closed
gopherbot opened this issue Aug 14, 2020 · 3 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 14, 2020

@mundaym requested issue #40796 to be considered for backport to the next 1.14 minor release.

@gopherbot Please open backport issues.

This bug can cause tracebacks to hang. There is no workaround. The fix for this issue will need to be backported before the test added in CL 247697 can be backported.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Aug 20, 2020

Change https://golang.org/cl/249443 mentions this issue: cmd/internal/obj: stop removing NOPs from instruction stream

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Sep 2, 2020

Approving per discussion in a release meeting. This backport applies to both 1.15 (#40798) and 1.14 (this issue).

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Sep 3, 2020

Closed by merging dd953de to release-branch.go1.14.

@gopherbot gopherbot closed this Sep 3, 2020
gopherbot pushed a commit that referenced this issue Sep 3, 2020
…truction stream

This has already been done for s390x, ppc64. This CL is for
all the other architectures.

Fixes #40797

Change-Id: Idd1816e057df63022d47e99fa06617811d8c8489
Reviewed-on: https://go-review.googlesource.com/c/go/+/248684
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
(cherry picked from commit 46ca7b5)
Reviewed-on: https://go-review.googlesource.com/c/go/+/249443
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.