Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: package documentation should immediately reflect UI changes #40807

Open
shaqque opened this issue Aug 15, 2020 · 7 comments
Open

x/pkgsite: package documentation should immediately reflect UI changes #40807

shaqque opened this issue Aug 15, 2020 · 7 comments

Comments

@shaqque
Copy link
Contributor

@shaqque shaqque commented Aug 15, 2020

Currently, we need to reprocess the database on any UI changes (e.g. changes to the HTML templates), which can take several hours. Users who request packages that were not yet reprocessed will see the old HTML version, which when coupled with potentially new CSS changes, can have unexpected results. See #40078

We should allow the frontend to prioritize the reprocessing of any package that a user requests, so that users will always see the latest UI changes when viewing documentation.

@shaqque shaqque self-assigned this Aug 15, 2020
@gopherbot gopherbot added this to the Unreleased milestone Aug 15, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 15, 2020

Change https://golang.org/cl/248677 mentions this issue: internal/postgres: update module status in version_map when reprocessing

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 15, 2020

Change https://golang.org/cl/248678 mentions this issue: internal/postgres: allow using resolvedVersion to get version_map entry

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 15, 2020

Change https://golang.org/cl/248679 mentions this issue: internal/fronted: prioritize reprocessing of packages requested by user

gopherbot pushed a commit to golang/pkgsite that referenced this issue Aug 18, 2020
Currently, the worker only updates the module_version_states table to
mark that modules need to be reprocessed. Update the module status in
the version_map table too.

For golang/go#40807

Change-Id: I9a1ecf611a71f1d3dda3d7d7b20d17012a995ca3
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/248677
Run-TryBot: Shaquille Que <shaquille@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/dochtml Aug 19, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 20, 2020

Change https://golang.org/cl/249447 mentions this issue: internal/{postgres, worker}: update modules.status column for fetching and reprocessing

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 21, 2020

Change https://golang.org/cl/249739 mentions this issue: internal/{postgres, worker}: update modules.status column for fetching and reprocessing

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 22, 2020

Change https://golang.org/cl/249841 mentions this issue: internal: prioritize reprocessing of packages requested by user

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 3, 2020

Change https://golang.org/cl/253080 mentions this issue: internal/postgres: set modules.status when updating module_version_states

gopherbot pushed a commit to golang/pkgsite that referenced this issue Sep 9, 2020
…ates

Populate the new modules.status column whenever we insert or update
module_version_states.status, in the same transaction.

After this code is deployed, we should manually update NULL
modules.status values to match module_version_states.status.

This CL implements part of https://golang.org/cl/c/pkgsite/+/249447.

For golang/go#40807

Change-Id: I8623fd71207b6578ff03de09ee12d292b36465b5
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/253080
Reviewed-by: Julie Qiu <julie@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.