Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: some 386 builders fails after CL 244917 #40808

Closed
cuonglm opened this issue Aug 15, 2020 · 7 comments
Closed

cmd/compile: some 386 builders fails after CL 244917 #40808

cuonglm opened this issue Aug 15, 2020 · 7 comments

Comments

@cuonglm
Copy link
Contributor

@cuonglm cuonglm commented Aug 15, 2020

After CL 244917, some 386 builders fails, e.g:

https://build.golang.org/log/d7370db05067093ad2de2afd5cadd573bcfcf779

It's not clear to my why, any idea @mdempsky 馃

@cuonglm cuonglm changed the title cmd/compile: some 386 builder fails after CL 244917 cmd/compile: some 386 builders fails after CL 244917 Aug 15, 2020
@mdempsky
Copy link
Member

@mdempsky mdempsky commented Aug 15, 2020

Seems like it affects all 32-bit architectures. E.g., reproduce locally with:

$ cd $GOROOT/test
$ go build run.go
$ GOARCH=386 ./run -- fixedbugs/issue39292.go
$ GOARCH=arm ./run -- fixedbugs/issue39292.go
$ GOARCH=mips ./run -- fixedbugs/issue39292.go
$ GOARCH=mipsle ./run -- fixedbugs/issue39292.go
@cuonglm
Copy link
Contributor Author

@cuonglm cuonglm commented Aug 15, 2020

Seems like it affects all 32-bit architectures. E.g., reproduce locally with:

$ cd $GOROOT/test
$ go build run.go
$ GOARCH=386 ./run -- fixedbugs/issue39292.go
$ GOARCH=arm ./run -- fixedbugs/issue39292.go
$ GOARCH=mips ./run -- fixedbugs/issue39292.go
$ GOARCH=mipsle ./run -- fixedbugs/issue39292.go

Only freebsd 11_2 386 passed.

@mdempsky
Copy link
Member

@mdempsky mdempsky commented Aug 15, 2020

Oh, lol, it's because the threshold for forcing heap allocations is 64kB, and an array of [10000]*int has size 80kB (>64kB) on 64-bit architectures, but 40kB (<64kB) on 32-bit architectures.

I think bumping the array length from 10,000 to 20,000 should be fine.

Only freebsd 11_2 386 passed.

I wouldn't be surprised if that builder skips running regression tests.

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 15, 2020

Change https://golang.org/cl/248697 mentions this issue: Revert "cmd/compile: handle OCLOSURE/OCALLPART in mustHeapAlloc check"

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 15, 2020

Change https://golang.org/cl/248680 mentions this issue: test: bump array size in fixedbugs/issue39292.go

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 15, 2020

Change https://golang.org/cl/248698 mentions this issue: test: bump array length to 20000 for testing issue 39292

@gopherbot gopherbot closed this in 69d34e2 Aug 15, 2020
@mdempsky
Copy link
Member

@mdempsky mdempsky commented Aug 15, 2020

@cuonglm Thanks for flagging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can鈥檛 perform that action at this time.