Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: add a work-around for file watching bug in VS Code #40812

Open
stamblerre opened this issue Aug 15, 2020 · 0 comments
Open

x/tools/gopls: add a work-around for file watching bug in VS Code #40812

stamblerre opened this issue Aug 15, 2020 · 0 comments

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Aug 15, 2020

VS Code currently does not allow the language server to watch files outside of the workspace root: microsoft/vscode#100870.

This means that users who open subdirectories of modules or modules with replace directives may see bugs because gopls's view of the workspace state is incorrect.

@heschik has suggested that we should add a work-around to address this -- we could clear out the entire cache when we see >= 10 (or fewer?) batched didChangeWatchedFiles notifications. We can do this for any module with a replace directive or for any workspace whose root is not the module root.

@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Aug 15, 2020
@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Needs Triage to Non-critical in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre removed this from Non-critical in vscode-go: gopls by default Dec 16, 2020
@stamblerre stamblerre removed this from the gopls/vscode-go milestone Dec 16, 2020
@stamblerre stamblerre added this to the gopls/unplanned milestone Dec 16, 2020
@stamblerre stamblerre removed this from the gopls/unplanned milestone Dec 18, 2020
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Dec 18, 2020
@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default via automation Dec 21, 2020
@stamblerre stamblerre removed this from the gopls/v1.0.0 milestone Dec 21, 2020
@stamblerre stamblerre added this to the gopls/vscode-go milestone Dec 21, 2020
@stamblerre stamblerre removed this from Needs Triage in vscode-go: gopls by default Jan 6, 2021
@stamblerre stamblerre removed this from the gopls/vscode-go milestone Jan 6, 2021
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Jan 6, 2021
@stamblerre stamblerre added this to To Do in gopls on-deck Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants