Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: add regression tests for file watching #40818

Open
stamblerre opened this issue Aug 16, 2020 · 0 comments
Open

x/tools/gopls: add regression tests for file watching #40818

stamblerre opened this issue Aug 16, 2020 · 0 comments

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Aug 16, 2020

Some cases that lack coverage:

  • Moving a declaration to a new file
  • Adding a new declaration to the same file
  • Adding a new declaration a different file
  • Check that closing a buffer clears errors
    • Real-life example: You switch branches with 1 open file in your editor and see errors because that file is now an overlay. You close the file and its errors clear.
@stamblerre stamblerre added the Testing label Aug 16, 2020
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Aug 16, 2020
@stamblerre stamblerre added this to To Do in gopls/v1.0.0 Aug 26, 2020
@stamblerre stamblerre moved this from To Do to Testing in gopls/v1.0.0 Aug 26, 2020
@stamblerre stamblerre changed the title x/tools/gopls: add more file change regression tests x/tools/gopls: tracking issue for additional regression tests Sep 9, 2020
@stamblerre stamblerre changed the title x/tools/gopls: tracking issue for additional regression tests x/tools/gopls: add regression tests for file watching Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.