Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: bug due to typo in (*.internal/types.Type).cmp for TSSA #40837

Closed
Celision opened this issue Aug 17, 2020 · 4 comments
Closed

cmd/compile: bug due to typo in (*.internal/types.Type).cmp for TSSA #40837

Celision opened this issue Aug 17, 2020 · 4 comments

Comments

@Celision
Copy link

@Celision Celision commented Aug 17, 2020

xname := t.Extra.(string)

xname := t.Extra.(string)

should ACTUALLY BE:

xname := x.Extra.(string)
@odeke-em
Copy link
Member

@odeke-em odeke-em commented Aug 17, 2020

Thank you @PraxisProject for this report and welcome to the Go project! Great catch with a code audit, we’ve had that in for 3 years. If you’ve got time could you please send a patch and you’ll become a Go contributor too.

/cc @josharian @randall77

@odeke-em odeke-em added the NeedsFix label Aug 17, 2020
@odeke-em odeke-em changed the title Go/src/cmd/compile/internal/types/type.go line 1029 typo/error! cmd/compile: bug due to typo in (*.internal/types.Type).cmp for TSSA Aug 17, 2020
@josharian josharian added this to the Go1.16 milestone Aug 18, 2020
ReewassSquared pushed a commit to Celision/go that referenced this issue Aug 18, 2020
@Celision
Copy link
Author

@Celision Celision commented Aug 18, 2020

Heyo. Submitted PR.

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 18, 2020

Change https://golang.org/cl/248780 mentions this issue: cmd/compile: resolve typo in (*.internal/types.Type).cmp

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 18, 2020

Change https://golang.org/cl/248781 mentions this issue: cmd/compile: fix SSA type comparison

@gopherbot gopherbot closed this in a745171 Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.