Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: "=== PAUSE" lines do not change the test name for the next log line [1.15 backport] #40849

Closed
gopherbot opened this issue Aug 17, 2020 · 3 comments
Closed

testing: "=== PAUSE" lines do not change the test name for the next log line [1.15 backport] #40849

gopherbot opened this issue Aug 17, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Milestone
Go1.15.2

Comments

@gopherbot
Copy link
Contributor

@bcmills requested issue #40657 to be considered for backport to the next 1.15 minor release.

@gopherbot, please backport to 1.14 and 1.15: this is likely a regression from the original 1.14 release.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 17, 2020
@gopherbot gopherbot mentioned this issue Aug 17, 2020
Closed
@gopherbot gopherbot added this to the Go1.15.1 milestone Aug 17, 2020
@bcmills bcmills changed the title cmd/test2json: "=== PAUSE" lines erroneously change the current test name [1.15 backport] testing: "=== PAUSE" lines do not change the test name for the next log line Aug 17, 2020
@bcmills bcmills changed the title testing: "=== PAUSE" lines do not change the test name for the next log line testing: "=== PAUSE" lines do not change the test name for the next log line [1.15 backport] Aug 17, 2020
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/249097 mentions this issue: [release-branch.go1.15] testing: treat PAUSE lines as changing the active test name

@cagedmantis
Copy link
Contributor

Approved as this is a critical issue without any workaround.

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Aug 28, 2020
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 28, 2020
@dmitshur dmitshur modified the milestones: Go1.15.1, Go1.15.2 Sep 1, 2020
gopherbot pushed a commit that referenced this issue Sep 1, 2020
[release-branch.go1.15] testing: treat PAUSE lines as changing the ac…
0ffc567 
…tive test name

We could instead fix cmd/test2json to treat PAUSE lines as *not*
changing the active test name, but that seems like it would be more
confusing to humans, and also wouldn't fix tools that parse output
using existing builds of cmd/test2json.

Fixes #40849
Updates #40657

Change-Id: I937611778f5b1e7dd1d6e9f44424d7e725a589ed
Reviewed-on: https://go-review.googlesource.com/c/go/+/248727
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jean de Klerk <deklerk@google.com>
(cherry picked from commit cdc77d3)
Reviewed-on: https://go-review.googlesource.com/c/go/+/249097
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link
Contributor Author

Closed by merging 0ffc567 to release-branch.go1.15.

claucece pushed a commit to claucece/go that referenced this issue Oct 22, 2020
@claucece
[release-branch.go1.15] testing: treat PAUSE lines as changing the ac…
8bbd9f4 
…tive test name

We could instead fix cmd/test2json to treat PAUSE lines as *not*
changing the active test name, but that seems like it would be more
confusing to humans, and also wouldn't fix tools that parse output
using existing builds of cmd/test2json.

Fixes golang#40849
Updates golang#40657

Change-Id: I937611778f5b1e7dd1d6e9f44424d7e725a589ed
Reviewed-on: https://go-review.googlesource.com/c/go/+/248727
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jean de Klerk <deklerk@google.com>
(cherry picked from commit cdc77d3)
Reviewed-on: https://go-review.googlesource.com/c/go/+/249097
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.15.2
Development

No branches or pull requests
4 participants
@cagedmantis @dmitshur @bcmills @gopherbot