Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: horizontal scrollbar shows needlessly #40858

Closed
myitcv opened this issue Aug 18, 2020 · 6 comments
Closed

x/pkgsite: horizontal scrollbar shows needlessly #40858

myitcv opened this issue Aug 18, 2020 · 6 comments

Comments

@myitcv
Copy link
Member

@myitcv myitcv commented Aug 18, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.59 Safari/537.36

Screenshot

Screen Shot 2020-08-18 at 11 55 18

What did you do?

  • Visit the above page
  • Start typing in the search box

What did you expect to see?

No horizontal scrollbar

What did you see instead?

The horizontal scrollbar appears

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Aug 18, 2020

I can't reproduce this issue at 100% zoom:

Half-screen width:
Screen Shot 2020-08-18 at 9 26 12 AM

Full-screen width:
Screen Shot 2020-08-18 at 9 26 54 AM

/cc @jamalc to investigate

@myitcv
Copy link
Member Author

@myitcv myitcv commented Aug 18, 2020

FYI this only happens when working on my MacBook Pro with no external device attached, and the resolution scaled to "More space" (i.e. highest resolution)

@andybons
Copy link
Member

@andybons andybons commented Aug 18, 2020

@myitcv something looks like it’s overflowing. Can you repro this in an incognito window as well?

@myitcv
Copy link
Member Author

@myitcv myitcv commented Aug 19, 2020

Can you repro this in an incognito window as well?

Yes, I can.

The horizontal scrollbar appears to be showing in order to deal with the reduced amount of horizontal space because the vertical scrollbar is showing - I'll emphasise that's a pure guess given the amount of scrolling that appears possible with the horizontal scrollbar.

@Omkar76
Copy link

@Omkar76 Omkar76 commented Jan 27, 2021

Are you still facing this issue? I believe I fixed this in golang/pkgsite#18 for an another issue.
/cc @myitcv

@myitcv
Copy link
Member Author

@myitcv myitcv commented Jan 29, 2021

Thanks - doesn't appear to be an issue any longer.

@myitcv myitcv closed this Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants