Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: licence not yet showing up after it was added to a module #40863

Closed
gnuy opened this issue Aug 18, 2020 · 2 comments
Closed

x/pkgsite: licence not yet showing up after it was added to a module #40863

gnuy opened this issue Aug 18, 2020 · 2 comments

Comments

@gnuy
Copy link

@gnuy gnuy commented Aug 18, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/gnuy/subdivx-get

What is your user agent?

Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:79.0) Gecko/20100101 Firefox/79.0

Screenshot

DeepinScreenshot_select-area_20200818120421

What did you do?

Created a Go project on GitHub without a license and added that license later. I'm filing this issue as recommended here.

What did you expect to see?

The license in the site being the MIT license.

What did you see instead?

The license in the site is still no legal advice

@gopherbot gopherbot added this to the Unreleased milestone Aug 18, 2020
@dmitshur dmitshur changed the title x/pkgsite: x/pkgsite: licence not yet showing up after it was added to a module Aug 18, 2020
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Aug 18, 2020

Version v0.0.0 (1a772ed) of the github.com/gnuy/subdivx-get module is being displayed in the screenshot you shared. That version does not have a LICENSE file:

https://github.com/gnuy/subdivx-get/tree/1a772eddf252/LICENSE (404)

The LICENSE file was added 2 hours ago in commit 2219d5c4.

It seems that this is working as intended. When pkg.go.dev starts displaying the newer version of the module, it should recognize the license.

/cc @julieqiu @jba @jamalc per owners.

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Aug 18, 2020

I just refreshed the version. You should see that https://pkg.go.dev/github.com/gnuy/subdivx-get now has license MIT.

image

@julieqiu julieqiu closed this Aug 18, 2020
@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/licenses Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants