Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: "Frequently asked questions" hyperlinks have insufficient color contrast #40907

Closed
julieqiu opened this issue Aug 19, 2020 · 2 comments
Closed
Labels
Milestone

Comments

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Aug 19, 2020

The hyperlinks in <h3> of the site footer lack sufficient color contrast against the background of the <div class="Questions-content">. The hyperlink color should be made darker or the background of the div class should be made lighter.

/cc @jamalc

@gopherbot gopherbot added this to the Unreleased milestone Aug 19, 2020
@Piyushhbhutoria
Copy link

@Piyushhbhutoria Piyushhbhutoria commented Aug 20, 2020

I would like to work on it. Need some more insight for this issue

@jamalc
Copy link
Member

@jamalc jamalc commented Aug 20, 2020

Hi @Piyushhbhutoria thank you for your interest. This color contrast on the FAQ links was already fixed in a previous commit. I'll close the issue.

@jamalc jamalc closed this Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants