Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/exp/cmd/gorelease: allow major version comparisons #40913

Open
carnott-snap opened this issue Aug 19, 2020 · 1 comment
Open

x/exp/cmd/gorelease: allow major version comparisons #40913

carnott-snap opened this issue Aug 19, 2020 · 1 comment

Comments

@carnott-snap
Copy link

@carnott-snap carnott-snap commented Aug 19, 2020

Currently gorelease does not allow comparing between major versions. E.g. (on v2.0.0) gorelease -base v1.0.0 yields:

gorelease: can't compare major versions: base version v1.0.0 does not belong to module path/to/module/v2

While I can understand that this is not part of the normal release flow, it is incredibly useful for generating changelog data, or just figuring out what changed between two releases. Furthermore this is annoying to do with apidiff directly, because it requires NEW be discoverable in the main module:

git checkout v1.0.0
apidiff path/to/module path/to/module/v2

/cc @jayconrod

@gopherbot gopherbot added this to the Unreleased milestone Aug 19, 2020
@carnott-snap carnott-snap changed the title x/exp/cmd/gorelease: allow cross version comparisons x/exp/cmd/gorelease: allow major version comparisons Aug 19, 2020
@jayconrod
Copy link
Contributor

@jayconrod jayconrod commented Aug 19, 2020

This is a subset of #39666, which should be fixed by CL 238839 as soon as that's reviewed.

Leaving this open to be fixed by another CL though since it would be handy to say -base=v1.0.0 instead of -base=example.com/mod@v1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants