Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: don't tee /_ah/* requests from godoc.org #40915

Closed
julieqiu opened this issue Aug 19, 2020 · 1 comment
Closed

x/pkgsite: don't tee /_ah/* requests from godoc.org #40915

julieqiu opened this issue Aug 19, 2020 · 1 comment

Comments

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Aug 19, 2020

As described in #39702, the teeproxy was implemented as a way to forward requests from godoc.org to pkg.go.dev and ensure that pkg.go.dev can handle the current workload of godoc.org.

We shouldn't tee any requests from AppEngine, such as /_ah/ready.

A filter was previously implemented here:
https://github.com/golang/gddo/blob/051695c33a3fcf220bffc5815eebc4b0a346c983/gddo-server/main.go#L1042

However, we are still seeing these requests via the teeproxy.

/cc @shaqque

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 20, 2020

Change https://golang.org/cl/249438 mentions this issue: internal/teeproxy: don't tee App Engine requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants