Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: go1.10.8 release tag mismatch source/binary from golang.org #40918

Closed
zhangyoufu opened this issue Aug 20, 2020 · 3 comments
Closed

x/build: go1.10.8 release tag mismatch source/binary from golang.org #40918

zhangyoufu opened this issue Aug 20, 2020 · 3 comments

Comments

@zhangyoufu
Copy link

@zhangyoufu zhangyoufu commented Aug 20, 2020

go1.10.8 was tagged at commit b0cb374 [release-branch.go1.10-security] go1.10.8, while the actually shipped source/binary from golang.org is commit bd0449f [release-branch.go1.10] all: merge release-branch.go1.10-security into release-branch.go1.10.

@ALTree
Copy link
Member

@ALTree ALTree commented Aug 20, 2020

Not sure trying to retroactively change this would be advisable, since it's an old release...

but cc @dmitshur @andybons

@ALTree ALTree changed the title release tag mismatch source/binary from golang.org go1.10.8 release tag mismatch source/binary from golang.org Aug 20, 2020
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Aug 20, 2020

Thanks for spotting and reporting this.

This is indeed an old release which is not supported by now, so we're unlikely to make any changes to it.

However, we should investigate to see if this is a valid issue. If so, we should understand what happened, and ensure have measures in place so a problem of this kind doesn't happen in future releases.

Those two commits have identical trees:

$ git diff b0cb374daf646454998bac7b393f3236a2ab6aca bd0449f8d16a5ac1b1962c7ea07d764a7f18eca7
$

How did you determine which commit was used in the release?

@dmitshur dmitshur changed the title go1.10.8 release tag mismatch source/binary from golang.org x/build: go1.10.8 release tag mismatch source/binary from golang.org Aug 20, 2020
@gopherbot gopherbot added the Builders label Aug 20, 2020
@gopherbot gopherbot added this to the Unreleased milestone Aug 20, 2020
@zhangyoufu
Copy link
Author

@zhangyoufu zhangyoufu commented Aug 20, 2020

I was confused by commit c731a7d on release-branch.go1.10. It was cherry-picked to ed3af1d on release-branch.go1.10-security. Then merge back to release-branch.go1.10 at bd0449f.

I was applying some patch to 1.10.8, generated by git format-patch go.1.10.8..my-branch. It generated a patch series including 0001-release-branch.go1.10-net-pass-if-at-least-one-match.patch, which fails to apply to 1.10.8 source/binary downloaded from golang.org, because the changes are already there.

Sorry for the noise.

@zhangyoufu zhangyoufu closed this Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.