Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: add tests to TestCreatePackageHeader where isLatest = true #40941

Closed
julieqiu opened this issue Aug 21, 2020 · 6 comments
Closed

x/pkgsite: add tests to TestCreatePackageHeader where isLatest = true #40941

julieqiu opened this issue Aug 21, 2020 · 6 comments
Labels
NeedsFix Suggested help wanted pkgsite
Milestone
Unreleased

Comments

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Aug 21, 2020

TestCreatePackage only tests for cases where isLatest = false:

https://github.com/golang/pkgsite/blob/master/internal/frontend/header_test.go#L140

We should add test cases for isLatest = true.
@gopherbot gopherbot added this to the Unreleased milestone Aug 21, 2020
@julieqiu julieqiu changed the title x/pkgsite: add tests to TestCreatePackageHeader where isLatest = true x/pkgsite: add tests to TestCreatePackageHeader where isLatest = true Aug 21, 2020
@julieqiu julieqiu added pkgsite NeedsFix help wanted Suggested labels Aug 21, 2020
@rahulw
Copy link

@rahulw rahulw commented Aug 21, 2020

Please let me know if I can add this test case
@julieqiu
Copy link
Contributor Author

@julieqiu julieqiu commented Aug 21, 2020

Please do, @rahulw!
@rahulw
Copy link

@rahulw rahulw commented Aug 21, 2020

Thanks. I will start work on this very soon.
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 22, 2020

Change https://golang.org/cl/249957 mentions this issue: x/pkgsite: fix UT TestCreatePackage
@ShaileshSurya
Copy link

@ShaileshSurya ShaileshSurya commented Aug 22, 2020

Hi @rahulw, I am really sorry that I had not claimed this bug and started working on it. I was also unaware that you have already claimed this bug. Sorry for the confusion. If you don't mind can I take this further?
@rahulw
Copy link

@rahulw rahulw commented Aug 23, 2020

Hey @ShaileshSurya, please feel free to submit the code. Thanks
@gopherbot gopherbot closed this in golang/pkgsite@812bcd2 Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix Suggested help wanted pkgsite
Projects
None yet
Milestone
Unreleased
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@rahulw @julieqiu @gopherbot @ShaileshSurya