Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: subdirectories tab for k8s.io/kubernetes overflows table #40946

Closed
julieqiu opened this issue Aug 21, 2020 · 4 comments
Closed

x/pkgsite: subdirectories tab for k8s.io/kubernetes overflows table #40946

julieqiu opened this issue Aug 21, 2020 · 4 comments
Labels
NeedsFix Suggested help wanted pkgsite
Milestone
Unreleased

Comments

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Aug 21, 2020

The content on https://pkg.go.dev//k8s.io/kubernetes overflows the table:

image

Setting max-width: 30rem on .Directories td seems to fix this page:

image

/cc @jamalc
@gopherbot gopherbot added this to the Unreleased milestone Aug 21, 2020
@julieqiu julieqiu added NeedsFix pkgsite labels Aug 21, 2020
@rahulw
Copy link

@rahulw rahulw commented Aug 21, 2020

Can I take this issue?
@julieqiu
Copy link
Contributor Author

@julieqiu julieqiu commented Aug 21, 2020

Go ahead, thanks @rahulw!
@julieqiu julieqiu added help wanted Suggested labels Aug 21, 2020
@rahulw
Copy link

@rahulw rahulw commented Aug 21, 2020

Created a pull request on the pkgsite repo - golang/pkgsite#4
rahulw added a commit to rahulw/pkgsite that referenced this issue Aug 21, 2020
@rahulw
x/pkgsite: Fix the width of Subdirectories table
88f996e 
The subdirectories table is overflowing for package
k8s.io/kubernetes hence adding a maximum width
to the table.

Fixes golang/go#40946
rahulw added a commit to rahulw/pkgsite that referenced this issue Aug 21, 2020
@rahulw
x/pkgsite: Fix the width of Subdirectories table
ea918f1 
The subdirectories table is overflowing for package
https://pkg.go.dev//k8s.io/kubernetes hence adding a maximum
width to the table.

Fixes golang/go#40946
@rahulw rahulw mentioned this issue Aug 21, 2020
Closed
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 21, 2020

Change https://golang.org/cl/249839 mentions this issue: x/pkgsite: Fix the width of Subdirectories table
@gopherbot gopherbot closed this in golang/pkgsite@99719cd Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix Suggested help wanted pkgsite
Projects
None yet
Milestone
Unreleased
Linked pull requests

Successfully merging a pull request may close this issue.

x/pkgsite: Fix the width of Subdirectories table
3 participants
@rahulw @julieqiu @gopherbot