Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: UpsertSearchDocuments should not store synopsis for non-redistributable packages #40971

Closed
jba opened this issue Aug 21, 2020 · 1 comment

Comments

@jba
Copy link
Contributor

@jba jba commented Aug 21, 2020

If a package is not redistributable, we can't store its doc synopsis. That decision should happen at the DataSource (that is, DB) level, in UpsertSearchDocuments.

It's not quite a trivial change because we also have to consider the flag for bypassing license checks, which UpsertSearchDocuments currently can't see because it's on the postgres.DB struct.

@jba jba added the pkgsite label Aug 21, 2020
@jba jba added this to the pkgsite/search milestone Aug 21, 2020
@jba jba self-assigned this Aug 21, 2020
@julieqiu julieqiu added the NeedsFix label Aug 22, 2020
@jba jba removed the Documentation label Aug 24, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 25, 2020

Change https://golang.org/cl/250637 mentions this issue: internal/postgres: enforce redistributability and allow bypass for search

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants