Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.15 only (regression from rc2?): strange rounding error on aarch64 #40981

Closed
eclipseo opened this issue Aug 22, 2020 · 2 comments
Closed

Go 1.15 only (regression from rc2?): strange rounding error on aarch64 #40981

eclipseo opened this issue Aug 22, 2020 · 2 comments

Comments

@eclipseo
Copy link

@eclipseo eclipseo commented Aug 22, 2020

What version of Go are you using (go version)?

Go 1.15

Does this issue reproduce with the latest release?

I don't know yet.

What operating system and processor architecture are you using (go env)?

aarch64 on Fedora Linux Rawhide.

What did you do?

I'm running tests from https://github.com/bmizerany/perks/blob/master/quantile/stream_test.go#L38

On rc2 tests were running fine, on the release version, it fails with:

--- FAIL: TestQuantRandMergeQuery (1.48s)
    stream_test.go:64: len: 1000000
    stream_test.go:68: perc50: want 4.614347960868212e+18, got 4.760105623190372e+18
    stream_test.go:69: e: 0.031588
FAIL

(on aarch64 only)

You can see it on our dependency tracker:
https://koschei.fedoraproject.org/package/golang-github-bmizerany-perks?collection=f34

Build 49111068 2020-08-11 21:42:59: Tests pass using Go 1.15-0.rc2.0.fc33
Build 49300049 2020-08-15 09:33:57 Tests fail on aarch64 using Go 1.15-1.fc34

Is there any change between rc2 and release which could cause this error?
github.com/bmizerany/perks is not really maintained anymore so there hasn't been any changes since several years, and no other Golang dependency is involved.

@eclipseo
Copy link
Author

@eclipseo eclipseo commented Aug 22, 2020

It seems the only change that has happened is cbc69e8#diff-4701ae2512a19891803c2963d9025cce

@eclipseo
Copy link
Author

@eclipseo eclipseo commented Aug 22, 2020

Not a bug, maybe a random fluke of the build system.

@eclipseo eclipseo closed this Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.