Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: TestPreemptionAfterSyscall is flaky on Plan 9 #41015

Open
bcmills opened this issue Aug 24, 2020 · 16 comments
Open

runtime: TestPreemptionAfterSyscall is flaky on Plan 9 #41015

bcmills opened this issue Aug 24, 2020 · 16 comments
Labels
NeedsInvestigation OS-Plan9 Testing
Milestone

Comments

@bcmills bcmills added NeedsInvestigation Testing labels Aug 24, 2020
@bcmills bcmills added this to the Backlog milestone Aug 24, 2020
@bcmills
Copy link
Member Author

@bcmills bcmills commented Aug 24, 2020

CC @aclements; this may relate to #36365.

@bcmills
Copy link
Member Author

@bcmills bcmills commented Sep 9, 2020

@bcmills
Copy link
Member Author

@bcmills bcmills commented Nov 5, 2020

@bcmills
Copy link
Member Author

@bcmills bcmills commented Nov 5, 2020

2020-11-04T16:54:48-594b4a3/plan9-amd64-9front
2020-11-02T13:02:40-7be8358/openbsd-arm-jsing
2020-10-15T18:35:44-1bcf6be/plan9-amd64-9front
2020-09-10T15:48:36-d7ab277/plan9-386-0intro
2020-08-24T16:53:02-fb5c3ea/plan9-386-0intro
2020-08-20T15:14:12-c57c021/plan9-386-0intro
2020-08-15T05:58:24-c0dded0/plan9-386-0intro
2020-07-01T14:41:56-7799756/plan9-amd64-9front
2020-05-28T22:17:10-107ebb1/plan9-386-0intro
2020-05-27T15:26:40-902d8de/dragonfly-amd64-5_8
2020-05-19T04:10:43-c88f698/plan9-amd64-9front
2020-05-08T17:12:27-55361a2/plan9-386-0intro
2020-05-05T05:13:26-9b18968/plan9-amd64-9front
2020-05-01T20:39:53-cb00d93/plan9-amd64-9front
2020-04-28T01:38:32-5c22c01/plan9-amd64-9front
2020-04-23T22:02:12-a44d06d/plan9-386-0intro
2020-03-20T16:05:33-ab5a40c/plan9-amd64-9front
2020-03-20T14:28:59-776a9d0/plan9-amd64-9front
2020-03-20T08:42:30-9d468f4/plan9-amd64-9front
2020-03-20T00:27:02-a0917eb/plan9-386-0intro
2020-03-19T00:08:40-b3b174f/plan9-amd64-9front
2020-03-18T19:44:13-0205790/plan9-amd64-9front
2020-03-18T18:59:32-e39de05/plan9-amd64-9front
2020-03-17T23:02:30-971f8a2/plan9-amd64-9front
2020-03-11T20:02:18-efc832b/plan9-amd64-9front
2020-03-05T21:51:02-fadbf74/plan9-amd64-9front
2020-03-05T00:40:38-bfb903f/plan9-386-0intro
2020-02-29T21:37:47-2962c96/plan9-386-0intro
2020-02-22T04:31:41-059a5ac/plan9-386-0intro
2020-02-21T23:20:22-d67d044/plan9-amd64-9front
2020-02-13T19:49:45-3eab754/plan9-amd64-9front
2020-01-15T22:02:44-f77e7ed/plan9-amd64-9front
2020-01-03T19:05:59-421cefd/plan9-386-0intro
2019-12-12T17:47:19-100bf44/dragonfly-amd64
2019-12-11T15:43:50-ef3ef8f/plan9-amd64-9front
2019-12-06T05:10:34-6ef7794/windows-386-2008
2019-11-16T00:02:02-5042317/plan9-386-0intro
2019-11-06T19:48:05-0054723/plan9-amd64-9front
2019-11-06T17:02:19-4cb9260/plan9-amd64-9front
2019-11-06T02:49:10-de70de6/plan9-amd64-9front
2019-11-05T18:58:41-f07cbc7/plan9-amd64-9front
2019-11-05T18:02:45-9514914/plan9-amd64-9front
2019-11-05T14:34:56-79a00a3/plan9-amd64-9front
2019-11-05T05:22:07-3c0fbee/plan9-amd64-9front
2019-11-05T03:50:54-979d65d/plan9-amd64-9front
2019-11-05T03:42:29-9a0a824/plan9-amd64-9front
2019-11-05T00:26:30-b3bd7ab/plan9-amd64-9front
2019-11-05T00:17:34-04e80fb/plan9-amd64-9front
2019-11-04T23:41:34-383b447/plan9-amd64-9front
2019-11-04T17:19:36-1da575a/plan9-amd64-9front
2019-11-04T15:18:34-d3660e8/plan9-amd64-9front
2019-11-01T00:04:51-4a09a9b/plan9-amd64-9front
2019-10-29T19:20:52-07b72d9/plan9-amd64-9front
2019-10-25T17:59:32-3d457f1/plan9-amd64-9front
2019-10-25T16:31:41-00d6b28/plan9-amd64-9front
2019-10-23T22:59:54-758eb02/plan9-amd64-9front
2019-10-23T18:41:38-7833302/plan9-amd64-9front
2019-10-18T04:44:26-d8e8d09/plan9-amd64-9front
2019-10-17T22:27:31-8c6876e/plan9-amd64-9front
2019-10-16T03:09:29-86f40a2/plan9-amd64-9front
2019-10-16T00:05:37-c4817f5/plan9-amd64-9front
2019-10-11T19:57:32-fd33b2c/plan9-amd64-9front
2019-10-11T17:28:42-426bfbe/plan9-amd64-9front
2019-10-08T19:00:51-decf9f6/plan9-amd64-9front
2019-10-08T10:03:04-6ec4c71/plan9-amd64-9front
2019-10-04T18:07:46-0fb95e7/plan9-amd64-9front
2019-09-30T00:45:38-843fec1/plan9-amd64-9front
2019-09-26T17:56:30-0816593/plan9-amd64-9front
2019-09-26T16:25:30-0ad3686/plan9-amd64-9front
2019-09-25T22:24:41-8c99e45/plan9-amd64-9front
2019-09-25T18:10:57-fad0a14/plan9-amd64-9front
2019-09-25T09:22:38-0f7b4e7/plan9-amd64-9front
2019-09-25T04:18:18-7fc2625/plan9-amd64-9front
2019-09-24T16:15:36-904fdb3/plan9-amd64-9front
2019-09-24T15:21:08-eb4e5de/plan9-amd64-9front
2019-09-24T10:23:40-2dfff36/plan9-amd64-9front
2019-09-23T22:33:23-211932b/plan9-amd64-9front
2019-09-19T16:26:58-fe2ed50/plan9-amd64-9front
2019-09-11T16:48:56-85c60bd/plan9-amd64-9front
2019-09-11T00:56:39-8ef6d6a/plan9-amd64-9front
2019-09-10T23:01:30-b970487/plan9-amd64-9front
2019-09-06T18:03:49-2da9c3e/plan9-amd64-9front
2019-09-06T16:59:11-d535501/plan9-386-0intro
2019-09-03T17:50:54-a71967e/plan9-amd64-9front
2019-09-03T14:27:24-88ca80b/plan9-amd64-9front
2019-09-02T14:47:38-2f04903/plan9-amd64-9front
2019-09-01T02:31:50-d15dfdc/plan9-386-0intro
2019-09-01T02:31:50-d15dfdc/plan9-amd64-9front
2019-08-31T00:57:57-bac5b3f/plan9-amd64-9front
2019-08-30T19:28:35-4219aec/plan9-amd64-9front
2019-08-27T16:46:34-69ff0ba/plan9-amd64-9front
2019-07-29T21:07:49-01d1372/plan9-amd64-9front
2019-07-28T18:09:57-c4ca603/plan9-amd64-9front
2019-07-16T22:31:35-0cadf40/plan9-amd64-9front
2019-07-15T16:53:05-b9edee3/plan9-amd64-9front
2019-07-10T15:51:50-0067586/plan9-amd64-9front
2019-07-09T01:49:44-06ef108/plan9-386-0intro
2019-07-08T14:31:42-fbaf881/plan9-amd64-9front
2019-06-26T19:48:40-c19b3a6/plan9-amd64-9front
2019-06-21T21:02:09-1803ab1/plan9-amd64-9front
2019-06-19T18:19:01-b373d31/plan9-amd64-9front
2019-06-19T18:13:09-7119f4b/plan9-amd64-9front
2019-06-18T19:30:06-cb0f0d6/plan9-amd64-9front
2019-06-12T22:17:38-c0c6cee/plan9-amd64-9front
2019-06-11T21:50:05-f2a4c13/plan9-amd64-9front
2019-06-10T23:21:57-5545301/plan9-amd64-9front
2019-06-10T17:04:55-350f71f/plan9-amd64-9front
2019-06-09T16:23:11-323212b/plan9-amd64-9front
2019-06-06T19:56:56-d32ec38/plan9-amd64-9front
2019-06-06T19:56:53-7d65e3a/plan9-amd64-9front
2019-06-05T21:21:59-fc70527/plan9-amd64-9front
2019-06-03T18:50:30-38c129b/plan9-amd64-9front
2019-06-02T19:28:21-ce656af/plan9-amd64-9front
2019-05-30T22:29:29-ba66d89/plan9-amd64-9front
2019-05-30T22:02:03-103b5b6/plan9-amd64-9front
2019-05-23T01:39:41-3e9d8e2/plan9-amd64-9front
2019-05-22T12:52:33-b0e238a/plan9-amd64-9front
2019-05-22T04:43:25-648c7b5/plan9-amd64-9front
2019-05-21T20:15:52-41329c0/plan9-amd64-9front
2019-05-21T14:19:32-d0aca57/plan9-amd64-9front
2019-05-20T02:21:25-be9f10b/plan9-amd64-9front
2019-05-20T01:53:24-5eeb372/plan9-amd64-9front
2019-05-17T17:33:16-3f7c560/plan9-amd64-9front
2019-05-17T16:13:45-f353385/plan9-amd64-9front
2019-05-10T23:47:49-f61cf6f/plan9-386-0intro

@bcmills
Copy link
Member Author

@bcmills bcmills commented Nov 20, 2020

@bcmills
Copy link
Member Author

@bcmills bcmills commented Mar 25, 2021

@bcmills
Copy link
Member Author

@bcmills bcmills commented Apr 16, 2021

@bcmills
Copy link
Member Author

@bcmills bcmills commented Apr 22, 2021

@bcmills
Copy link
Member Author

@bcmills bcmills commented Apr 26, 2021

@bcmills
Copy link
Member Author

@bcmills bcmills commented Jan 5, 2022

This affects multiple platforms, including windows/386 and windows/amd64 (which are first-class ports and also run as TryBots). Marking as release-blocker.

(CC @jeremyfaller for routing.)

@bcmills bcmills removed this from the Backlog milestone Jan 5, 2022
@bcmills bcmills added this to the Go1.18 milestone Jan 5, 2022
@bcmills
Copy link
Member Author

@bcmills bcmills commented Jan 5, 2022

Curiously, the windows failures all appear to be exclusively on the -2008 builders, and the majority of other failures are on plan9 builders.

Depending on how important this test is, it could perhaps be resolved (or at least reduced back to the backlog) by skipping on those specific builders.

@aclements
Copy link
Member

@aclements aclements commented Jan 18, 2022

@cherrymui observed that the Windows failures are all just slightly over the 3 second timeout, so I think the best course here is to up the timeout slightly and skip the test on plan9.

@gopherbot
Copy link

@gopherbot gopherbot commented Jan 18, 2022

Change https://golang.org/cl/379214 mentions this issue: runtime: deflake TestPreemptionAfterSyscall

@aclements aclements changed the title runtime: TestPreemptionAfterSyscall is flaky runtime: TestPreemptionAfterSyscall is flaky on Plan 9 Jan 19, 2022
@aclements aclements removed this from the Go1.18 milestone Jan 19, 2022
@aclements aclements added this to the Unplanned milestone Jan 19, 2022
gopherbot pushed a commit that referenced this issue Jan 19, 2022
This test occasionally takes very slightly longer than the 3 second
timeout on slow builders (especially windows-386-2008), so increase
the timeout to 5 seconds. It fails with much longer timeouts on Plan
9, so skip it as flaky there.

Updates #41015.

Change-Id: I426a7adfae92c18a0f8a223dd92762b0b91565e1
Reviewed-on: https://go-review.googlesource.com/c/go/+/379214
Trust: Austin Clements <austin@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
@aclements
Copy link
Member

@aclements aclements commented Jan 19, 2022

The slightly higher timeout should fix this on most platforms. This bug now tracks the test skip on Plan 9 and, as such, is no longer a release blocker.

jproberts pushed a commit to jproberts/go that referenced this issue Jun 21, 2022
This test occasionally takes very slightly longer than the 3 second
timeout on slow builders (especially windows-386-2008), so increase
the timeout to 5 seconds. It fails with much longer timeouts on Plan
9, so skip it as flaky there.

Updates golang#41015.

Change-Id: I426a7adfae92c18a0f8a223dd92762b0b91565e1
Reviewed-on: https://go-review.googlesource.com/c/go/+/379214
Trust: Austin Clements <austin@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation OS-Plan9 Testing
Projects
None yet
Development

No branches or pull requests

3 participants