net/http: Transport.CancelRequest no longer cancels in-flight request [1.14 backport] #41016
Labels
Milestone
Comments
Change https://golang.org/cl/250299 mentions this issue: |
Approved because this is a critical problem without a workaround. |
Closed by merging 9017642 to release-branch.go1.14. |
gopherbot
pushed a commit
that referenced
this issue
Aug 27, 2020
…readTrackingBody wrapper Use the original *Request in the reqCanceler map, not the transient wrapper created to handle body rewinding. Change the key of reqCanceler to a struct{*Request}, to make it more difficult to accidentally use the wrong request as the key. Updates #40453. Fixes #41016. Change-Id: I4e61ee9ff2c794fb4c920a3a66c9a0458693d757 Reviewed-on: https://go-review.googlesource.com/c/go/+/245357 Run-TryBot: Damien Neil <dneil@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Russ Cox <rsc@golang.org> Reviewed-on: https://go-review.googlesource.com/c/go/+/250299 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Damien Neil <dneil@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@dmitshur requested issue #40453 to be considered for backport to the next 1.14 minor release.
The text was updated successfully, but these errors were encountered: