Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: Transport.CancelRequest no longer cancels in-flight request [1.14 backport] #41016

Closed
gopherbot opened this issue Aug 24, 2020 · 3 comments
Closed

net/http: Transport.CancelRequest no longer cancels in-flight request [1.14 backport] #41016

gopherbot opened this issue Aug 24, 2020 · 3 comments
Labels
CherryPickApproved
Milestone
Go1.14.9

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 24, 2020

@dmitshur requested issue #40453 to be considered for backport to the next 1.14 minor release.

@gopherbot Please backport to Go 1.14.

This is a second fixup to a previous fix (CL 242117) for an approved backport issue #39279. We can't submit that CL without this one (and #40973). This needs to be backported to Go 1.14 only, since the fix is already included in Go 1.1​5.
@gopherbot gopherbot mentioned this issue Aug 24, 2020
Closed
@gopherbot gopherbot added this to the Go1.14.8 milestone Aug 24, 2020
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Aug 24, 2020

Change https://golang.org/cl/250299 mentions this issue: [release-branch.go1.14] net/http: fix cancelation of requests with a readTrackingBody wrapper
@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Aug 27, 2020

Approved because this is a critical problem without a workaround.
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Aug 27, 2020

Closed by merging 9017642 to release-branch.go1.14.
@gopherbot gopherbot closed this Aug 27, 2020
gopherbot pushed a commit that referenced this issue Aug 27, 2020
@neild @dmitshur
[release-branch.go1.14] net/http: fix cancelation of requests with a …
9017642 
…readTrackingBody wrapper

Use the original *Request in the reqCanceler map, not the transient
wrapper created to handle body rewinding.

Change the key of reqCanceler to a struct{*Request}, to make it more
difficult to accidentally use the wrong request as the key.

Updates #40453.
Fixes #41016.

Change-Id: I4e61ee9ff2c794fb4c920a3a66c9a0458693d757
Reviewed-on: https://go-review.googlesource.com/c/go/+/245357
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/250299
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
@dmitshur dmitshur modified the milestones: Go1.14.8, Go1.14.9 Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved
Projects
None yet
Milestone
Go1.14.9
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@cagedmantis @dmitshur @gopherbot