Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: support custom initial workspace load patterns #41019

Open
stamblerre opened this issue Aug 25, 2020 · 2 comments
Open

x/tools/gopls: support custom initial workspace load patterns #41019

stamblerre opened this issue Aug 25, 2020 · 2 comments

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Aug 25, 2020

The ./ and ./... patterns used for the initial workspace load are specific to go list and may not be supported by other go/packages drivers. We should allow users to specify their own patterns based on their drivers via a configuration.

@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Aug 25, 2020
@ianthehat
Copy link

@ianthehat ianthehat commented Aug 25, 2020

When we talked about this during the go/packages design we decided that the meanings of some of the core go list patterns would be required for all drivers, and it was up to the driver to translate to something approximately meaningful.

@ianthehat
Copy link

@ianthehat ianthehat commented Aug 25, 2020

Also, I think this is probably not needed for 1.0 (nobody is using a different driver yet as far as I can tell)

@stamblerre stamblerre removed this from the gopls/v1.0.0 milestone Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.