Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: Cleanup races with Logf and Errorf [1.15 backport] #41034

Closed
gopherbot opened this issue Aug 25, 2020 · 4 comments
Closed

testing: Cleanup races with Logf and Errorf [1.15 backport] #41034

gopherbot opened this issue Aug 25, 2020 · 4 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 25, 2020

@bcmills requested issue #40908 to be considered for backport to the next 1.15 minor release.

@gopherbot, please backport to 1.15. This is a fairly subtle race condition, and the fix is small and contained.

@bcmills
Copy link
Member

@bcmills bcmills commented Aug 25, 2020

This was a regression from Go 1.14.7, which is not affected by the race.

(And that means it is likely that tests written against Go 1.14 will inadvertently trigger the race when run with Go 1.15.)

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Aug 25, 2020

Change https://golang.org/cl/250617 mentions this issue: [release-branch.go1.15] testing: fix Cleanup race with Logf and Errorf

@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Aug 27, 2020

Approved because this is a critical problem without a workaround.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Aug 27, 2020

Closed by merging 45265c2 to release-branch.go1.15.

@gopherbot gopherbot closed this Aug 27, 2020
gopherbot pushed a commit that referenced this issue Aug 27, 2020
Updates #40908
Fixes #41034

Change-Id: I25561a3f18e730a50e6fbf85aa7bd85bf1b73b6e
Reviewed-on: https://go-review.googlesource.com/c/go/+/250078
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit 00a053b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/250617
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Reviewed-by: Michał Łowicki <mlowicki@gmail.com>
@dmitshur dmitshur modified the milestones: Go1.15.1, Go1.15.2 Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.