net/http: add Transport.GetProxyConnectHeader #41048
Closed
Comments
Potential implementation: tailscale@6db6825 (licensed+CLA'd for use by Go) (Lacking tests for now.) |
The Get is a bit non-standard but it does follow our pattern of having Does anyone object to this? |
Based on the discussion above, this seems like a likely accept. |
No change in consensus, so accepted. |
Change https://golang.org/cl/259917 mentions this issue: |
Change https://golang.org/cl/285594 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Jan 22, 2021
For #40700 For #41048 Change-Id: Ida6bcaaf5edaa2bba9ba2b8e02ec9959481f8302 Reviewed-on: https://go-review.googlesource.com/c/go/+/285594 Trust: Ian Lance Taylor <iant@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
net/http.Transport currently has:
https://golang.org/pkg/net/http/#Transport.ProxyConnectHeader
... but it's static for the life of the Transport.
Some authentication modes like NTLM/Kerberos/Negotiate require a dynamic header value, which currently requires making a new Transport for each request going through a proxy. That's heavy, as the Transport is the unit of connection reuse.
Proposal:
The text was updated successfully, but these errors were encountered: