Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: github.com/gotailwindcss/tailwind not updated after adding license #41055

Closed
bradleypeabody opened this issue Aug 27, 2020 · 5 comments
Closed

Comments

@bradleypeabody
Copy link

@bradleypeabody bradleypeabody commented Aug 27, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/gotailwindcss/tailwind?tab=overview

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.135 Safari/537.36

Screenshot

image

What did you do?

Browsed to https://pkg.go.dev/github.com/gotailwindcss/tailwind?tab=overview - noticed missing license message, added, license, refreshed paged multiple times over the course of several hours.

What did you expect to see?

The documentation, or at least a different error message. Commit reference should be latest commit 18fbd6a

I also would expect some mechanism or instructions linked from somewhere on this page to indicate how to force/request an update if it is not automatic.

What did you see instead?

It shows message about missing license. License was added about 3 hours ago: gotailwindcss/tailwind@09b9e3f

The commit mentioned, 91cc231, is from 3 days ago.

No indication of how to refresh or otherwise correct the problem (at least that I could see/find).

@gopherbot gopherbot added this to the Unreleased milestone Aug 27, 2020
@cagedmantis cagedmantis changed the title x/pkgsite: https://pkg.go.dev/github.com/gotailwindcss/tailwind not updated after adding license x/pkgsite: github.com/gotailwindcss/tailwind not updated after adding license Aug 27, 2020
@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Aug 27, 2020

@jba
Copy link
Contributor

@jba jba commented Aug 27, 2020

See the instructions under "Adding a package" on https://go.dev/about. Basically, someone has to go get a version through the proxy for us to eventually see it. We haven't seen 09b... yet.

@bradleypeabody
Copy link
Author

@bradleypeabody bradleypeabody commented Aug 27, 2020

Thanks and I did get this to work by visiting https://proxy.golang.org/github.com/gotailwindcss/tailwind/@latest and then https://proxy.golang.org/github.com/gotailwindcss/tailwind/@v/18fbd6a.info and then waiting for a bit.

Can I suggest something like the following to make this process more obvious:

  • A link on the Overview page for the package, perhaps called something like "Update this Package".
  • That link should give a simple URL at proxy.golang.org to cause such an update to occur, rather than requiring the maintainer to construct it.
  • It should cover how repos that do not yet have explicit version numbers work (common for new projects just being created before they have a roadmap). E.g. I'm still not clear on which of the above URLs caused the update, because of the caching. I'm sure I could carefully read through the documentation on proxy.golang.org to figure out exactly what happened, but...
  • I also hazard that it should not require me to have to understand how proxy.golang.org works in order to use it.
  • It should set the expectation that there is a cache timeout for the new update to appear.

My rationale on this is that as a maintainer, the most common thing I would want to do with pkg.go.dev is "update this to the latest", and while now I understand more about the process, it has not been particularly obvious how all this is supposed to work, and specifically what I need to do as a maintainer to get my stuff to show up as quickly as possible.

@jba
Copy link
Contributor

@jba jba commented Aug 27, 2020

If you visit the URL path YOUR_MODULE@master, it will 404 with a button to load the latest version.

We can consider putting that button on the overview page.

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Sep 8, 2020

Closing this issue, since https://pkg.go.dev/github.com/gotailwindcss/tailwind has been updated. I'll open a separate issue for the suggestions in #41055 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants