Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: acquire on destroyed generation in UpgradeMod #41056

Closed
stamblerre opened this issue Aug 27, 2020 · 2 comments
Closed

x/tools/gopls: acquire on destroyed generation in UpgradeMod #41056

stamblerre opened this issue Aug 27, 2020 · 2 comments
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Aug 27, 2020

Information about the case in which this happened (I'm not able to reproduce it).
To be fair, the module I was working from was in a very bad state (a lot of Saving 'go.mod': Getting code actions from ''Go Nightly'' (configure). pop-ups.)

The change I made to bring this about was change the go.mod from:

module mod5.com

go 1.14

require (
	github.com/cockroachdb/apd/v2 v2.0.1
)

replace (
	github.com/cockroachdb/apd/v2 v2.0.1 => /Users/rstambler/code/src/golang.org/x/tools
)

to

module mod5.com

go 1.14

require (
	github.com/cockroachdb/apd/v2 v2.0.1
)

mod5.zip
gopls.log

@stamblerre stamblerre added this to the gopls/v0.5.0 milestone Aug 27, 2020
@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Sep 2, 2020

/cc @heschik

Not sure if there's anything that can be done at this point, but wanted to let you know that I saw this.

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 2, 2020

Change https://golang.org/cl/252437 mentions this issue: internal/lsp/cache: use the right snapshot in ModUpgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.